Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve enrollment dialog (dev) (WPB-4372) #2613

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jan 23, 2024

TaskWPB-4372 [Android] Misleading Backend Enrollment Dialogue


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

CHERRY PICK OF

We need to provide in the deeplink enrollment dialog to a custom backend more information about the links

Causes (Optional)

Security requirement.

Solutions

  • Refactor the dialog component, to make scrollable the dynamic content.
  • Pass the new deeplink data to display in the dialog.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Manually tested, open a deeplink, you should see more information.

Attachments (Optional)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina requested a review from a team January 23, 2024 17:24
@yamilmedina yamilmedina self-assigned this Jan 23, 2024
@yamilmedina yamilmedina requested review from borichellow, vitorhugods, Garzas, ohassine and saleniuk and removed request for a team January 23, 2024 17:24
Copy link
Contributor

github-actions bot commented Jan 23, 2024

Test Results

750 tests  ±0   750 ✅ ±0   8m 29s ⏱️ - 1m 20s
105 suites ±0     0 💤 ±0 
105 files   ±0     0 ❌ ±0 

Results for commit 83ea041. ± Comparison against base commit 06b1be8.

♻️ This comment has been updated with latest results.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2699 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina added the cherry-pick PR is cherry-picking changes from another banch label Jan 24, 2024
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@yamilmedina yamilmedina added this pull request to the merge queue Jan 24, 2024
@AndroidBob
Copy link
Collaborator

Build 2703 succeeded.

The build produced the following APK's:

Merged via the queue into develop with commit 833422a Jan 24, 2024
13 of 14 checks passed
@yamilmedina yamilmedina deleted the feat/improve-enrollment-dialog-dev branch January 24, 2024 10:26
@yamilmedina yamilmedina restored the feat/improve-enrollment-dialog-dev branch January 24, 2024 11:21
@yamilmedina yamilmedina deleted the feat/improve-enrollment-dialog-dev branch March 29, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/M
Projects
None yet
4 participants