Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): base64 encoding adding a new line after 76 char #2666

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

base64 encoding, adding a new line after 76 char

Solutions

add -w 0 flag to remove this behaviour

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina changed the title ci: base64 encoding adding a new line after 76 char chore(ci): base64 encoding adding a new line after 76 char Feb 6, 2024
@AndroidBob
Copy link
Collaborator

Build 2894 failed.

Copy link
Contributor

github-actions bot commented Feb 6, 2024

Test Results

789 tests   789 ✅  6m 40s ⏱️
107 suites    0 💤
107 files      0 ❌

Results for commit 8e5857a.

Copy link
Contributor

github-actions bot commented Feb 6, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@mchenani mchenani merged commit 5daa694 into release/candidate Feb 6, 2024
16 of 17 checks passed
@mchenani mchenani deleted the ci/base64-encoding-adding-a-new-line-after-76-char branch February 6, 2024 11:33
@AndroidBob
Copy link
Collaborator

Build 2897 succeeded.

The build produced the following APK's:

MohamadJaara added a commit that referenced this pull request Feb 6, 2024
Co-authored-by: Oussama Hassine <oussama.has100@gmail.com>

(cherry picked from commit 5daa694)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants