chore(ci): base64 encoding adding a new line after 76 char (#2666) #2667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Oussama Hassine <oussama.has100@gmail.com> (cherry picked from commit 5daa694)
|
Build 2904 failed. |
|
Build 2905 failed. |
|
Build 2906 failed. |
yamilmedina
approved these changes
Feb 6, 2024
yamilmedina
requested review from
a team,
typfel,
borichellow,
vitorhugods,
Garzas and
ohassine
and removed request for
a team
alexandreferris
approved these changes
Feb 6, 2024
vitorhugods
approved these changes
Feb 7, 2024
…ncoding-adding-a-new-line-after-76-char-dev # Conflicts: # kalium
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2667 +/- ##
===========================================
- Coverage 42.77% 42.77% -0.01%
===========================================
Files 404 404
Lines 13439 13440 +1
Branches 2372 2373 +1
===========================================
Hits 5749 5749
- Misses 7011 7012 +1
Partials 679 679 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 2962 succeeded. The build produced the following APK's: |
MohamadJaara
deleted the
chore(ci)-base64-encoding-adding-a-new-line-after-76-char-dev
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
base64 encoding, adding a new line after 76 char
Solutions
add -w 0 flag to remove this behaviour
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.