Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add fully qualified handle for external results (WPB-6256) #2676

Merged
merged 2 commits into from Feb 8, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Feb 8, 2024

BugWPB-6256 [Android] When searching for another user from another domain, his domain is not shown in search result anymore


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Visual regression in search results.

Causes (Optional)

Changes introduced recently to the search feature, to make it more reliable and handle big teams.

Solutions

Display fully qualified handle for external search results.

Testing

How to Test

Manually tested, login in a federated backend, your results should display the domain for not connected users and
highlight should be available too.

Attachments (Optional)

Before
1dc1961b-58f3-4e82-a170-d5d504f0635e

After
Check it out in the comment section of the jira ticket


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Feb 8, 2024
@yamilmedina yamilmedina requested review from MohamadJaara, a team, typfel, alexandreferris, mchenani and ohassine and removed request for a team February 8, 2024 16:13
@yamilmedina yamilmedina enabled auto-merge (squash) February 8, 2024 16:43
@yamilmedina yamilmedina merged commit 184a051 into release/candidate Feb 8, 2024
16 of 17 checks passed
@yamilmedina yamilmedina deleted the fix/search-domain-not-displayed branch February 8, 2024 16:54
Copy link
Contributor

github-actions bot commented Feb 8, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3004 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants