Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add fully qualified handle for external results (WPB-6256) #2677

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

AndroidBob
Copy link
Collaborator

@AndroidBob AndroidBob commented Feb 8, 2024

BugWPB-6256 [Android] When searching for another user from another domain, his domain is not shown in search result anymore

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Visual regression in search results.

Causes (Optional)

Changes introduced recently to the search feature, to make it more reliable and handle big teams.

Solutions

Display fully qualified handle for external search results.

Testing

How to Test

Manually tested, login in a federated backend, your results should display the domain for not connected users and
highlight should be available too.

Attachments (Optional)

Before
1dc1961b-58f3-4e82-a170-d5d504f0635e

After
Check it out in the comment section of the jira ticket


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. .

@AndroidBob AndroidBob added the cherry-pick PR is cherry-picking changes from another banch label Feb 8, 2024
@yamilmedina yamilmedina requested review from a team, yamilmedina, borichellow, MohamadJaara, vitorhugods and Garzas and removed request for a team February 8, 2024 17:10
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (8f8a6e1) 43.01% compared to head (e7be962) 42.87%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2677      +/-   ##
===========================================
- Coverage    43.01%   42.87%   -0.14%     
===========================================
  Files          405      405              
  Lines        13466    13468       +2     
  Branches      2377     2377              
===========================================
- Hits          5792     5775      -17     
- Misses        6994     7020      +26     
+ Partials       680      673       -7     
Files Coverage Δ
...in/kotlin/com/wire/android/mapper/ContactMapper.kt 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f8a6e1...e7be962. Read the comment docs.

@yamilmedina yamilmedina added this pull request to the merge queue Feb 8, 2024
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Test Results

816 tests  ±0   816 ✅ ±0   9m 37s ⏱️ - 6m 18s
114 suites ±0     0 💤 ±0 
114 files   ±0     0 ❌ ±0 

Results for commit e7be962. ± Comparison against base commit 8f8a6e1.

Copy link
Contributor

github-actions bot commented Feb 8, 2024

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit 0f6bace Feb 8, 2024
14 of 15 checks passed
@yamilmedina yamilmedina deleted the fix/search-domain-not-displayed-cherry-pick branch February 8, 2024 18:12
@AndroidBob
Copy link
Collaborator Author

Build 3007 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
3 participants