Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2ei): remove E2EI shield from remove device screen (WPB-6519) #2685

Conversation

mchenani
Copy link
Member

@mchenani mchenani commented Feb 12, 2024

BugWPB-6519 [Android] Remove e2ei shields in remove-devices screen in login flow


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

During the registration, if the user has too many clients registered, in the remove device screen we shouldn't show the E2EI shield.

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Have an account with too many clients, during the registration the E2EI shield shouldn't be visible in the screen.

Attachments (Optional)

After:
screenshot-1707744030013


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@mchenani mchenani merged commit 876f5da into release/candidate Feb 12, 2024
13 of 14 checks passed
@mchenani mchenani deleted the release/fix/remove-e2ei-shield-from-remove-device-screen branch February 12, 2024 13:59
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3057 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants