Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2ei): remove E2EI shield from remove device screen (WPB-6519) #2686

Conversation

AndroidBob
Copy link
Collaborator

@AndroidBob AndroidBob commented Feb 12, 2024

BugWPB-6519 [Android] Remove e2ei shields in remove-devices screen in login flow

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

During the registration, if the user has too many clients registered, in the remove device screen we shouldn't show the E2EI shield.

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Have an account with too many clients, during the registration the E2EI shield shouldn't be visible in the screen.

Attachments (Optional)

After:
screenshot-1707744030013


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. .

@AndroidBob AndroidBob added the cherry-pick PR is cherry-picking changes from another banch label Feb 12, 2024
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (32085af) 42.85% compared to head (4ac2f4b) 42.92%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2686      +/-   ##
===========================================
+ Coverage    42.85%   42.92%   +0.07%     
===========================================
  Files          408      408              
  Lines        13505    13506       +1     
  Branches      2388     2389       +1     
===========================================
+ Hits          5788     5798      +10     
+ Misses        7041     7025      -16     
- Partials       676      683       +7     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32085af...4ac2f4b. Read the comment docs.

Copy link
Contributor

Test Results

811 tests  ±0   811 ✅ ±0   14m 33s ⏱️ + 6m 8s
114 suites ±0     0 💤 ±0 
114 files   ±0     0 ❌ ±0 

Results for commit 4ac2f4b. ± Comparison against base commit 32085af.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator Author

Build 3059 succeeded.

The build produced the following APK's:

@mchenani mchenani added this pull request to the merge queue Feb 12, 2024
Merged via the queue into develop with commit 2118e42 Feb 12, 2024
15 checks passed
@mchenani mchenani deleted the release/fix/remove-e2ei-shield-from-remove-device-screen-cherry-pick branch February 12, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
4 participants