Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fetch 2000 team members dring sync [WPB-6483] #2704

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Feb 13, 2024

StoryWPB-6483 [Android] Fetch first page of team members during slow sync


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

WPB-6483

Solutions

add build time config to set the limit

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@AndroidBob
Copy link
Collaborator

Build 3120 failed.

@AndroidBob
Copy link
Collaborator

Build 3121 failed.

Copy link
Contributor

github-actions bot commented Feb 13, 2024

Test Results

802 tests   802 ✅  10m 7s ⏱️
108 suites    0 💤
108 files      0 ❌

Results for commit 53f3172.

♻️ This comment has been updated with latest results.

@MohamadJaara MohamadJaara requested review from a team, typfel, borichellow, vitorhugods, mchenani and ohassine and removed request for a team February 15, 2024 10:21
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3151 succeeded.

The build produced the following APK's:

@MohamadJaara MohamadJaara merged commit b9c734b into release/candidate Feb 15, 2024
15 checks passed
@MohamadJaara MohamadJaara deleted the feat/fetch-the-first-page-of-team-members-during-sync branch February 15, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants