Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fetch 2000 team members dring sync [WPB-6483] #2711

Conversation

AndroidBob
Copy link
Collaborator

@AndroidBob AndroidBob commented Feb 15, 2024

StoryWPB-6483 [Android] Fetch first page of team members during slow sync

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:
kalium


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

WPB-6483

Solutions

add build time config to set the limit

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. .

@AndroidBob AndroidBob added the cherry-pick PR is cherry-picking changes from another banch label Feb 15, 2024
Copy link
Contributor

github-actions bot commented Feb 15, 2024

Test Results

827 tests  ±0   827 ✅ ±0   14m 58s ⏱️ + 3m 14s
115 suites ±0     0 💤 ±0 
115 files   ±0     0 ❌ ±0 

Results for commit 23e1e9c. ± Comparison against base commit 41e7338.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator Author

Build 3153 failed.

@AndroidBob
Copy link
Collaborator Author

Build 3196 failed.

@AndroidBob
Copy link
Collaborator Author

Build 3227 failed.

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.24%. Comparing base (41e7338) to head (23e1e9c).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2711      +/-   ##
===========================================
+ Coverage    43.20%   43.24%   +0.04%     
===========================================
  Files          409      409              
  Lines        13571    13571              
  Branches      2396     2396              
===========================================
+ Hits          5863     5869       +6     
+ Misses        7022     7015       -7     
- Partials       686      687       +1     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41e7338...23e1e9c. Read the comment docs.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator Author

Build 3381 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina added this pull request to the merge queue Feb 29, 2024
@AndroidBob
Copy link
Collaborator Author

Build 3385 failed.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit 13475d1 Feb 29, 2024
13 of 14 checks passed
@yamilmedina yamilmedina deleted the feat/fetch-the-first-page-of-team-members-during-sync-cherry-pick branch February 29, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
4 participants