Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unexpected scrolling on selected message [WPB-6932] #2753

Merged
merged 2 commits into from Mar 1, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Feb 29, 2024

BugWPB-6932 On selected message, list unexpected scrolls to latest message


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

There is functionality which automatically scrolls when new message is added but it should not work when user selects message from search

Causes (Optional)

List scrolls to latest message from search instead of showing selected message

Solutions

Secure case when we open conversation screen from search

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

Before After
https://github.com/wireapp/wire-android/assets/13151239/8ac65d4a-cb07-4921-b0e8-7d771f983421 https://github.com/wireapp/wire-android/assets/13151239/491c2607-8144-4dd2-9bee-65af82987702

Copy link
Contributor

Test Results

809 tests   809 ✅  13m 24s ⏱️
109 suites    0 💤
109 files      0 ❌

Results for commit ca97b1e.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3408 succeeded.

The build produced the following APK's:

@Garzas Garzas enabled auto-merge (squash) March 1, 2024 08:14
@Garzas Garzas merged commit 1265e6b into release/candidate Mar 1, 2024
10 of 11 checks passed
@Garzas Garzas deleted the fix/selected-message-scroll branch March 1, 2024 08:39
Copy link
Contributor

github-actions bot commented Mar 1, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3418 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants