Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unexpected scrolling on selected message [WPB-6932] #2756

Merged
merged 3 commits into from
Mar 1, 2024

Conversation

AndroidBob
Copy link
Collaborator

@AndroidBob AndroidBob commented Mar 1, 2024

BugWPB-6932 On selected message, list unexpected scrolls to latest message

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:
app/src/main/kotlin/com/wire/android/ui/home/conversations/ConversationScreen.kt


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

There is functionality which automatically scrolls when new message is added but it should not work when user selects message from search

Causes (Optional)

List scrolls to latest message from search instead of showing selected message

Solutions

Secure case when we open conversation screen from search

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

Before After
https://github.com/wireapp/wire-android/assets/13151239/8ac65d4a-cb07-4921-b0e8-7d771f983421 https://github.com/wireapp/wire-android/assets/13151239/491c2607-8144-4dd2-9bee-65af82987702

@AndroidBob AndroidBob added the cherry-pick PR is cherry-picking changes from another banch label Mar 1, 2024
Copy link
Contributor

github-actions bot commented Mar 1, 2024

Test Results

827 tests  ±0   827 ✅ ±0   14m 56s ⏱️ -38s
115 suites ±0     0 💤 ±0 
115 files   ±0     0 ❌ ±0 

Results for commit 3d4b69a. ± Comparison against base commit 46ea2fe.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator Author

Build 3420 failed.

Copy link
Contributor

github-actions bot commented Mar 1, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator Author

Build 3426 succeeded.

The build produced the following APK's:

@ohassine ohassine enabled auto-merge March 1, 2024 16:28
@ohassine ohassine added this pull request to the merge queue Mar 1, 2024
Copy link
Contributor

github-actions bot commented Mar 1, 2024

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit 84d3737 Mar 1, 2024
13 of 14 checks passed
@ohassine ohassine deleted the fix/selected-message-scroll-cherry-pick branch March 1, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
4 participants