fix(calling): microphone restricted when the app goes into background on Android 14 (WPB-6307) #2780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohassine
requested review from
a team,
typfel,
yamilmedina,
borichellow,
MohamadJaara and
vitorhugods
and removed request for
a team
app/src/main/kotlin/com/wire/android/services/OngoingCallService.kt
Outdated
Show resolved
Hide resolved
alexandreferris
approved these changes
Mar 11, 2024
borichellow
approved these changes
Mar 11, 2024
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 9129c31. |
saleniuk
reviewed
Mar 11, 2024
app/src/main/kotlin/com/wire/android/notification/WireNotificationManager.kt
Show resolved
Hide resolved
MohamadJaara
approved these changes
Mar 11, 2024
saleniuk
approved these changes
Mar 11, 2024
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 3526 succeeded. The build produced the following APK's: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Microphone is restricted when the app goes into background during a call on Android 14.
Causes (Optional)
This issue was introduced when we upgraded the target SDK to API 34 because of some changes added to Android 14.
Solutions
As phoneCall as foreground service type is not enough to access the microphone in background, we added Microphone type to fix the issue on Android 14.
Needs releases with:
How to Test
Start a call on Android 14 device.
Put the app in the background.
The other person should still hear you.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.