Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(calling): microphone restricted when the app goes into background on Android 14 (WPB-6307) #2782

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

AndroidBob
Copy link
Collaborator

@AndroidBob AndroidBob commented Mar 11, 2024

BugWPB-6307 [Android] Bluetooth issue during screen Off

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:
kalium


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Microphone is restricted when the app goes into background during a call on Android 14.

Causes (Optional)

This issue was introduced when we upgraded the target SDK to API 34 because of some changes added to Android 14.

Solutions

As phoneCall as foreground service type is not enough to access the microphone in background, we added Microphone type to fix the issue on Android 14.

Needs releases with:

  • GitHub link to other pull request

How to Test

Start a call on Android 14 device.
Put the app in the background.
The other person should still hear you.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. .

@AndroidBob AndroidBob added the cherry-pick PR is cherry-picking changes from another banch label Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 43.47%. Comparing base (94d9786) to head (2d8abbe).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2782      +/-   ##
===========================================
+ Coverage    43.30%   43.47%   +0.16%     
===========================================
  Files          411      411              
  Lines        13850    13863      +13     
  Branches      2516     2517       +1     
===========================================
+ Hits          5998     6027      +29     
+ Misses        7153     7128      -25     
- Partials       699      708       +9     
Files Coverage Δ
...re/android/notification/WireNotificationManager.kt 78.46% <0.00%> (-0.48%) ⬇️
...in/com/wire/android/services/OngoingCallService.kt 3.27% <0.00%> (-0.81%) ⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94d9786...2d8abbe. Read the comment docs.

Copy link
Contributor

Test Results

857 tests  ±0   857 ✅ ±0   14m 19s ⏱️ + 5m 35s
116 suites ±0     0 💤 ±0 
116 files   ±0     0 ❌ ±0 

Results for commit 2d8abbe. ± Comparison against base commit 94d9786.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator Author

Build 3530 succeeded.

The build produced the following APK's:

@ohassine ohassine added this pull request to the merge queue Mar 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 11, 2024
@ohassine ohassine added this pull request to the merge queue Mar 12, 2024
Merged via the queue into develop with commit eba05a8 Mar 12, 2024
14 checks passed
@ohassine ohassine deleted the microphone_restricted_android_14-cherry-pick branch March 12, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
3 participants