Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: misleading e2ei certificate error dialog (WPB-7129) #2883

Merged

Conversation

alexandreferris
Copy link
Contributor

@alexandreferris alexandreferris commented Apr 11, 2024

BugWPB-7129 [Android] Misleading dialogue if certificate generation fails after login with e2ei enabled


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

The old copy for error when getting certificate was wrong.

Solutions

Adjust dialog with new copy

Dependencies (Optional)

Needs releases with:

Testing

How to Test

  • Have env. with E2EI enabled and wrong ACME URL
  • login and try to generate certificate
  • error dialog will popup with correct copy

Attachments (Optional)

Before After
old dialog copy new dialog copy

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Signed-off-by: alexandreferris <ferris.alexandre@gmail.com>
Signed-off-by: alexandreferris <ferris.alexandre@gmail.com>
Signed-off-by: alexandreferris <ferris.alexandre@gmail.com>
Copy link
Contributor

Test Results

816 tests   816 ✅  12m 47s ⏱️
110 suites    0 💤
110 files      0 ❌

Results for commit 245e7bf.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@alexandreferris alexandreferris requested review from a team, yamilmedina, vitorhugods, mchenani, Garzas and saleniuk and removed request for a team April 11, 2024 10:50
@AndroidBob
Copy link
Collaborator

Build 4120 succeeded.

The build produced the following APK's:

@alexandreferris alexandreferris merged commit bc12ea5 into release/candidate Apr 11, 2024
13 checks passed
@alexandreferris alexandreferris deleted the fix/misleading_e2ei_certificate_error_dialog branch April 11, 2024 13:57
github-actions bot pushed a commit that referenced this pull request Apr 11, 2024
Signed-off-by: alexandreferris <ferris.alexandre@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants