Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): separate lower KeyPackage limit and set to false (WPB-8685) #2927

Merged

Conversation

mchenani
Copy link
Member

@mchenani mchenani commented Apr 23, 2024

TaskWPB-8685 [Android] Increase keypackages amount to 100 again on all builds


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Introducing dedicated config flag for LoweringKeypackagesLimit and set to false as default.

Issues

The QA needs to have loweringKeyPackages in different builds configurable,


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@mchenani mchenani changed the title feat(config): separate lower KeyPackage limit and set to false feat(config): separate lower KeyPackage limit and set to false (WPB-8685) Apr 23, 2024
Copy link
Contributor

Test Results

819 tests   819 ✅  9m 17s ⏱️
110 suites    0 💤
110 files      0 ❌

Results for commit 49221ab.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4383 succeeded.

The build produced the following APK's:

@mchenani mchenani merged commit 2c071dd into release/candidate Apr 23, 2024
15 checks passed
@mchenani mchenani deleted the chore/separate-lower-keypackage-limit-and-disable branch April 23, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants