Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass conversation to onConversationItemClick callback #797

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

trOnk12
Copy link
Contributor

@trOnk12 trOnk12 commented Jul 26, 2022


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

onClickListener was not recreated with a state of Conversation changed , so when we muted the conversation it was not reflected in the UI

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

@gongracr gongracr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are we actually accomplishing with these changes in general?

@github-actions
Copy link
Contributor

Unit Test Results

  29 files  ±0    29 suites  ±0   26s ⏱️ -6s
179 tests ±0  179 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 742acfd. ± Comparison against base commit caa5572.

@AndroidBob
Copy link
Collaborator

Build 2 succeeded.

The build produced the following APK's:

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #797 (742acfd) into develop (caa5572) will increase coverage by 0.00%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             develop     #797   +/-   ##
==========================================
  Coverage      15.23%   15.24%           
  Complexity       371      371           
==========================================
  Files            241      241           
  Lines          10988    10990    +2     
  Branches        1791     1791           
==========================================
+ Hits            1674     1675    +1     
- Misses          9155     9156    +1     
  Partials         159      159           
Impacted Files Coverage Δ
...id/ui/home/conversationslist/ConversationRouter.kt 0.00% <0.00%> (ø)
...ome/conversationslist/ConversationListViewModel.kt 30.70% <50.00%> (+0.54%) ⬆️

@trOnk12
Copy link
Contributor Author

trOnk12 commented Jul 26, 2022

What are we actually accomplishing with these changes in general?

@gongracr onClickListener was not recreated with a state of Conversation changed , so when we muted the conversation it was not reflected in the UI

Copy link
Contributor

@MohammedMokresh MohammedMokresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix just a quick thing ,maybe we can add some description in the PR description section , so we will have a better reference if we look at this back later

@trOnk12 trOnk12 merged commit 959347f into develop Jul 26, 2022
@trOnk12 trOnk12 deleted the fix/muting_option_for_group branch July 26, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants