-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pass conversation to onConversationItemClick callback #797
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are we actually accomplishing with these changes in general?
Build 2 succeeded. The build produced the following APK's: |
Codecov Report
@@ Coverage Diff @@
## develop #797 +/- ##
==========================================
Coverage 15.23% 15.24%
Complexity 371 371
==========================================
Files 241 241
Lines 10988 10990 +2
Branches 1791 1791
==========================================
+ Hits 1674 1675 +1
- Misses 9155 9156 +1
Partials 159 159
|
@gongracr onClickListener was not recreated with a state of Conversation changed , so when we muted the conversation it was not reflected in the UI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice fix just a quick thing ,maybe we can add some description in the PR description section , so we will have a better reference if we look at this back later
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
onClickListener was not recreated with a state of Conversation changed , so when we muted the conversation it was not reflected in the UI
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.