Remove autoconnect functionality; deprecate end-point. #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisx
changed the title
mheinzel
suggested changes
Mar 6, 2020
services/brig/src/Brig/API.hs
Outdated
| ab <- parseJsonBody r | ||
| json <$> API.onboarding uid ab !>> connError | ||
| -- | DEPRECATED / does nothing. | ||
| onboardingH :: JSON ::: UserId ::: JsonRequest Value -> Handler Response |
There was a problem hiding this comment.
I think we still want to return {"results":[],"auto-connects":[]}, so clients don't choke on the response.
So we could either leave the MatchingResult type and do pure $ MatchingResult [] [] here, or just produce a JSON Value with the right fields.
Maybe this structure should also still be documented in Swagger.
|
Thanks! I am against keeping the swagger docs for the body type, but if you feel strongly about it let me know and I'll do it. |
fisx
force-pushed
the
fisx/deprecate-autoconnect-feature
branch
from
a59e159
to
3c2e01f
Compare
mheinzel
approved these changes
Mar 6, 2020
Merged
jschaul
added a commit
that referenced
this pull request
Aug 25, 2021
This is more dead code forgotten to be removed in #1005 when auto-connect was disabled.
4 tasks
jschaul
added a commit
that referenced
this pull request
Aug 26, 2021
This is more dead code forgotten to be removed in #1005 when auto-connect was disabled.
jschaul
added a commit
that referenced
this pull request
Dec 5, 2022
…ever read anymore since 'onboarding' / auto-connect was removed in #1005
2 tasks
jschaul
added a commit
that referenced
this pull request
Dec 5, 2022
…ever read anymore since 'onboarding' / auto-connect was removed in #1005
jschaul
added a commit
that referenced
this pull request
Dec 5, 2022
they are never read anymore since 'onboarding' / auto-connect was removed in #1005
jschaul
added a commit
that referenced
this pull request
Dec 6, 2022
they are never read anymore since 'onboarding' / auto-connect was removed in #1005
jschaul
added a commit
that referenced
this pull request
Dec 13, 2022
they are never read anymore since 'onboarding' / auto-connect was removed in #1005
jschaul
added a commit
that referenced
this pull request
Dec 14, 2022
They are never read anymore since 'onboarding' / auto-connect was removed in #1005
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/zinfra/backend-issues/issues/557#issuecomment-595668101