Cleanup: Remove cassandra queries to the user_keys_hash table #2902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
jschaul
force-pushed
the
remove-hashed-key-queries
branch
from
6581ffc
to
918ca7d
Compare
jschaul
force-pushed
the
remove-hashed-key-queries
branch
from
918ca7d
to
ff97fcd
Compare
jschaul
changed the title
jschaul
added a commit
that referenced
this pull request
Dec 6, 2022
Not needed anymore, see also #2902
jschaul
force-pushed
the
remove-hashed-key-queries
branch
from
ff97fcd
to
a6dc3e5
Compare
they are never read anymore since 'onboarding' / auto-connect was removed in #1005
jschaul
force-pushed
the
remove-hashed-key-queries
branch
from
3525b33
to
c7a37ab
Compare
jschaul
requested review from
smatting,
elland,
battermann,
pcapriotti and
mdimjasevic
battermann
approved these changes
Dec 13, 2022
tools/db/move-team/src/Work.hs
Outdated
| @@ -157,8 +157,6 @@ runFullScans env@Env {..} users = do | |||
| .| mapC (filter (haveId . view _2)) | |||
|
|
|||
| -- FUTUREWORK: no need to read this table, it can be populated from `brig.user` | |||
There was a problem hiding this comment.
maybe remove this comment as well?
jschaul
commented
Dec 13, 2022
|
The PR didn't run through the PR pipeline in CI. Is that a problem for this PR? |
mdimjasevic
reviewed
Dec 14, 2022
it ran in the past but had a flaky integration test. I rebased and pushed... and CI doesn't seem to pick it up anymore. |
no, this should be merged now, and reviewed now, only the cassandra schema change added after july 2023. |
|
CI ran after another commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As they are never read anymore since 'onboarding' / auto-connect was removed in #1005. See here for old code with past usage.
Checklist
changelog.d