Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up "make formatf" #2866

Merged
merged 3 commits into from
Nov 24, 2022
Merged

Speed up "make formatf" #2866

merged 3 commits into from
Nov 24, 2022

Conversation

smatting
Copy link
Contributor

@smatting smatting commented Nov 24, 2022 •
edited
Loading

This PR speeds up make formatf (not used on CI) by only restricting to files that

  • are changed in the branch compared to origin/develop
  • are changed compared to HEAD

This PR adds make formatf-all target that behaves like the the make formatf without this PR.

@smatting smatting temporarily deployed to cachix November 24, 2022 10:50 Inactive
@smatting smatting temporarily deployed to cachix November 24, 2022 10:50 Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Nov 24, 2022
@smatting smatting temporarily deployed to cachix November 24, 2022 10:54 Inactive
@smatting smatting temporarily deployed to cachix November 24, 2022 10:54 Inactive
elland
elland approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@elland elland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine by me but I'm not a bash expert.

@smatting smatting temporarily deployed to cachix November 24, 2022 11:06 Inactive
@smatting smatting temporarily deployed to cachix November 24, 2022 11:06 Inactive
@smatting smatting merged commit 6a94cfd into develop Nov 24, 2022
@smatting smatting deleted the smatting/formatf-faster branch November 24, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elland elland elland approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smatting @elland @zebot