Limit login retries #830
Merged
Limit login retries #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I'll make a PR to wire-server-deploy soon, but since the flag is optional, that can be done independently.) |
heh :) I guess i missed one after all: |
fisx
force-pushed
the
fisx/limit-login-retries
branch
from
14ad11a
to
e666d0b
Compare
services/brig/brig.integration.yaml
Outdated
| @@ -137,6 +137,9 @@ optSettings: | |||
| setUserCookieThrottle: | |||
| stdDev: 5 | |||
| retryAfter: 1 | |||
| limitFailedLogins: | |||
There was a problem hiding this comment.
sry, can u make it limitFailedLogins -> setLimitFailedLogins for consistency's sake?
This is slightly less accurate, but works against UTCTime, and is consistent with what we use in other places.
fisx
force-pushed
the
fisx/limit-login-retries
branch
from
2195d02
to
2a53fd4
Compare
|
(this will pass CI once the resp. PRs there have been deployed.) |
tiago-loureiro
approved these changes
Aug 19, 2019
There was a problem hiding this comment.
Just please double check https://github.com/wireapp/wire-server/pull/830/files#r315212362
This was referenced Aug 20, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements https://github.com/wearezeta/backend-issues/issues/841#issuecomment-518033685 .
Open questions:
forM_instead ofpooledForConcurrentlyN_here. The latter will fail becauseBridge.Budgetis not concurrency-proof: if two threads / services request a budget coin concurrently, only one of them will decrement the budget value in cassandra. We could use counters instead ofintin the schema, but it is unclear what that will mean for the other use case. (cases? i think there is only one.)Settingscan be changed at run-time, in which caseLoginRetryOptsshouldn't go there (I think).