Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Detect empty call logs #12393

Merged
merged 3 commits into from Jan 13, 2022
Merged

fix(core): Detect empty call logs #12393

merged 3 commits into from Jan 13, 2022

Conversation

atomrc
Copy link
Contributor

@atomrc atomrc commented Jan 13, 2022


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Use dynamic method to detect if a call log is meaningful or not.

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #12393 (7c2d6bf) into dev (5563223) will decrease coverage by 0.00%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##              dev   #12393      +/-   ##
==========================================
- Coverage   44.93%   44.93%   -0.01%     
==========================================
  Files         566      566              
  Lines       25757    25755       -2     
  Branches     4411     4412       +1     
==========================================
- Hits        11573    11572       -1     
+ Misses      13212    13211       -1     
  Partials      972      972              

@atomrc atomrc enabled auto-merge (squash) January 13, 2022 11:00
@atomrc atomrc merged commit 308edc6 into dev Jan 13, 2022
@atomrc atomrc deleted the fix/empty_call_log branch January 13, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants