refactor: Migrate WarningsViewModel to React #13748

thisisamir98 · 2022-09-28T13:24:12Z

codecov · 2022-09-28T13:44:51Z

Codecov Report

Merging #13748 (b773820) into acc (067c432) will increase coverage by 0.22%.
The diff coverage is 39.25%.

@@            Coverage Diff             @@
##              acc   #13748      +/-   ##
==========================================
+ Coverage   39.52%   39.75%   +0.22%     
==========================================
  Files         588      590       +2     
  Lines       20998    21016      +18     
  Branches     4611     4626      +15     
==========================================
+ Hits         8300     8355      +55     
+ Misses      11689    11634      -55     
- Partials     1009     1027      +18

przemvs

Try to remove all ampliy.publish/amplify.subscribe. Instead of this use renderElement maybe. I think we wanna remove all amplify functionality ?

src/script/calling/CallingRepository.ts

src/script/components/Modals/WarningModal/WarningModal.tsx

src/script/components/Modals/WarningModal/WarningModalState.ts

src/script/components/Modals/WarningModal/WarningModalTypes.ts

V-Gira

Can't really contribute anything but I really like the move to zustand too, feels like I can understand the state management without massive headaches for a change :)

atomrc · 2022-09-29T12:27:33Z

src/script/components/Modals/PrimaryModal/PrimaryModal.tsx

+};
+
+const PrimaryModal = {
+  add: addNewModalToQueue,


Suggested change

add: addNewModalToQueue,

show: addNewModalToQueue,

I think show makes a little more sense when we talk about modals. WDYT?

atomrc · 2022-09-29T14:26:28Z

src/script/components/Modals/PrimaryModal/PrimaryModal.tsx

+ *
+ */
+
+import React, {useState} from 'react';


Let's create a index.ts that exports the public API to the modal component.
So that we can use it by doing import ... from 'path/to/PrimaryModal instead of path/to/PrimaryModal/PrimaryModal

atomrc · 2022-09-29T14:31:06Z

src/script/components/Modals/PrimaryModal/PrimaryModal.tsx

+  addNewModalToQueue,
+} from './PrimaryModalState';
+
+export interface PrimaryModalProps {}


probably not needed :D

atomrc · 2022-09-29T14:32:32Z

src/script/components/Modals/PrimaryModal/PrimaryModal.tsx

+    renderElement<PrimaryModalProps>(PrimaryModalComponent)({});
+    showNextModalInQueue();
+  },
+  type: PrimaryModalType,


we could export this in its own export and in the index.ts file

atomrc · 2022-09-29T14:34:24Z

src/script/components/Modals/PrimaryModal/PrimaryModal.tsx

+    secondaryAction,
+    titleText,
+    closeBtnTitle,
+  } = content || defaultContent;


The default value should live only inside the state manager (the value it returns should be the default value and never be undefined if we don't expect it)

przemvs

Good job with replacing amplify!

Few comments more :)

przemvs · 2022-09-29T18:37:40Z

src/script/components/Modals/PrimaryModal/PrimaryModal.tsx

+                    className="modal__input"
+                    type="password"
+                    value={passwordValue}
+                    placeholder={inputPlaceholder ?? ''}


inputPlaceholder doesn't have default value (empty string) ?

przemvs · 2022-09-29T18:37:44Z

src/script/components/Modals/PrimaryModal/PrimaryModal.tsx

+                    maxLength={64}
+                    className="modal__input"
+                    value={inputValue}
+                    placeholder={inputPlaceholder ?? ''}


inputPlaceholder doesn't have default value (empty string) ?

przemvs · 2022-09-29T18:38:38Z

src/script/components/Modals/PrimaryModal/PrimaryModal.tsx

+              )}
+              <div className={cx('modal__buttons', {'modal__buttons--column': hasMultipleSecondary})}>
+                {secondaryActions
+                  .filter((action): action is Action => action !== null)


Maybe move this to guards/Modal.ts (isAction) or smth like that :)

this is a bit too much just for a null check

przemvs · 2022-09-29T18:40:07Z

src/script/components/Modals/PrimaryModal/PrimaryModal.tsx

+                  .filter((action): action is Action => action !== null)
+                  .map(action => (
+                    <button
+                      key={`${action?.text}-${action?.uieName}`}


Key can be 'undefined-undefined' - i think it's wrong.

przemvs · 2022-09-29T18:40:18Z

src/script/components/Modals/PrimaryModal/PrimaryModal.tsx

+                    <button
+                      key={`${action?.text}-${action?.uieName}`}
+                      type="button"
+                      onClick={() => action?.action && doAction(action?.action, true, true)}


Suggested change

onClick={() => action?.action && doAction(action?.action, true, true)}

onClick={() => action?.action && doAction(action.action, true, true)}

przemvs · 2022-09-29T18:40:58Z

src/script/components/Modals/PrimaryModal/PrimaryModal.tsx

+                        'modal__button--full': hasMultipleSecondary,
+                      })}
+                    >
+                      {action?.text}


Maybe add custom text if action didn't have any text.

przemvs · 2022-09-29T18:43:07Z

src/script/components/Modals/PrimaryModal/PrimaryModal.tsx

+  type: PrimaryModalType,
+};
+
+export default PrimaryModal;


I'm thinking about PrimaryModal name. for me it can be Modal - because it can be reused, PrimaryModal sounds like we have multiple Modal styles, or smth like that.

przemvs · 2022-09-29T18:45:01Z

src/script/components/Modals/PrimaryModal/PrimaryModalState.ts

+    closeFn: close,
+    closeOnConfirm,
+    currentType: type,
+    inputPlaceholder: text.input ?? null,


I think it can be empty string instead of null :)

przemvs · 2022-09-29T18:45:34Z

src/script/components/Modals/PrimaryModal/PrimaryModalState.ts

+    text = {} as Text,
+  } = options;
+  const content = {
+    checkboxLabel: text.option ?? null,


I'll go with string types instead of null for string values :)

przemvs · 2022-09-29T18:46:51Z

src/script/components/Modals/PrimaryModal/PrimaryModalTypes.ts

+  checkboxLabel: string | null;
+  closeFn: () => void;
+  closeOnConfirm?: boolean;
+  currentType: string | null;
+  inputPlaceholder: string | null;
+  messageHtml: string | null;
+  messageText: string | null;
+  modalUie: string;
+  onBgClick: () => void;
+  primaryAction: Action | null;
+  secondaryAction: Action[] | Action | null;
+  titleText: string | null;
+  closeBtnTitle?: string;


I'll go for string types as optional and without null. We can pass empty string for string :)

atomrc · 2022-10-03T09:27:23Z

src/script/components/Modals/PrimaryModal/PrimaryModal.test.tsx

+class PrimaryModalPage extends TestPage<{}> {
+  constructor() {
+    super(PrimaryModalComponent);
+  }
+
+  getWrapperElement = () => this.get('div#modals');
+  getPrimaryActionButton = () => this.get('[data-uie-name="do-action"]');
+  getSecondaryActionButton = () => this.get('[data-uie-name="do-secondary"]');
+}


Let's use @testing-library directly and all it's super nice primitives (like getByTestId).
You can inspire from what @PatrykBuniX has been doing lately migrating a few tests to testling-lib (cf https://github.com/wireapp/wire-webapp/pull/13751/files#diff-aa9cafe9a5b4c4728e53a5935e604adaf6c345a38a55778469861301792662e0R46)

przemvs

Code LGTM :)

PatrykBuniX

💪

* feat: add input bar to acc branch (#13488) * chore(deps): Bump crowdin/github-action from 1.4.11 to 1.4.12 (#13487) Bumps [crowdin/github-action](https://github.com/crowdin/github-action) from 1.4.11 to 1.4.12. - [Release notes](https://github.com/crowdin/github-action/releases) - [Commits](crowdin/github-action@1.4.11...1.4.12) --- updated-dependencies: - dependency-name: crowdin/github-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Revert "fix: revert input bar (#13484)" This reverts commit c113b32. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: input-bar reply theme colors (#13448) * fix: replying message in inputBar (#13453) * fix(input-bar): open modal after error (#13458) * runfix: address account preference page style changes acc-79 (#13423) * runfix: correct alignment of team and email input * center accent color picker * add focus and hover state to accent color picker * chore: merge dev and add css variables for UI kit button (#13491) * runfix: add primary button css variables * change theme id to default in root * change restore and bacup buttons to tertiary variant * replace links nin account preference by ui-kit links * style copy profile link button * apply correct focus color for accent color picker * chore: bump ui-kit to 8.13.3 * apply accent-color to default focus * allow keyboard navigation for link buttons Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Arjita <arjitamitra3@gmail.com> Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik96@gmail.com> Co-authored-by: Timothy LeBon <tlebon@gmail.com> Co-authored-by: Adrian Weiß <77456193+aweiss-dev@users.noreply.github.com> Co-authored-by: Amir Ghezelbash <thisisamir98@gmail.com> Co-authored-by: Otto the Bot <webapp+otto@wire.com> Co-authored-by: Sven Jost <mythsunwind@users.noreply.github.com> * refactor: migrate EmojiViewModel to React (#ACC-251) (#13493) * refactor: migrate EmojiViewModel to React (#ACC-251) * Remove any type * Update tests * CR Fixes * Build fixes * fix: Replace inline emoji (#13497) * fix: Sugesstion emoji (#13498) * fix: Sugesstion emoji * remove unecessary code * fix: emoji autocomplete fix (#13501) * fix: update emoji on enter click (#13507) * fix: update emoji on enter click * Remove unecessary code * refactor: migrate conenct-requests to react (#ACC-231) (#13397) * fix: useEmoji and InputBar types (#13527) * refactor: migrate history-export to react (#ACC-234) (#13420) * refactor: migrate history-export to react (#ACC-234) * Export history fixes * fix: user not mentioned in message (#13534) * bugfix: User not mentioned in message * fix for mention user * fix: reply message inputBar (#13536) * fix: accept last user connection request (#13537) * runfix: address changes to preferences acc-79 (#13494) * runfix: show focus correctly on sliders * change device button variant to tertiary * change position of back arrow to absolute and tweaks preference styles * update tests * make use of the withTheme util in tests * change button variant to tertiary in av preferences * update links to ui-kit version * solve jumping navigation items issue * add hover states to color picker * fix: list of devices screen reader announcement (#13531) remove device keyboard access focus style updated(ACC-249) * bump ui-kit to 8.13.5 Co-authored-by: Arjita <arjitamitra3@gmail.com> * fix: input bar deflake tests (#13540) * refactor: migrate history-import to react (#ACC-234) (#13421) * refactor: migrate history-import to react (#ACC-234) * Prepare migration history-import * fix variable name * fix: address hover and focus state of sidebar call-ui acc-80 (#13548) * fix: address hover and focus state of sidebar call-ui acc-80 * set context menu to open on key down * refactor: migrate detail-view to React (#ACC-239) (#13426) * refactor: migrate detail-view to React (#ACC-239) * Iterate index fixes * CR fixes * CR CHanges * Send file fix * fixes * Fix for added image message * code changes * runfix: add pseudo class styles to toggle dot acc-81 (#13579) * runfix: correct focus states of toggle dots acc-81 (#13582) * runfix: correct focus states of toggle dots acc-81 * address cr: refactor device toggle button into a native button * runfix: apply correct styles to status buttons and bump ui-kit (#13583) * refactor: Migrate ConversationDetails component to React (#ACC-258) (#13602) * refactor: Migrate ConversationDetails component to React (#ACC-258) * cr fixes * prepare fixes * cr fixes * Add TODO messages * fix: webapp screen reader accessibility improvements (#13584) * feat: improve accessibility(ACC-21) improve accessibility of conversation info, search people, devices, profile picture screens * feat: improve accessibility of profile, conversation, devices, group participants, chat messages, edit profile(ACC-21) * fix: delete for me/everyone modal close btn aria label(ACC-21) * fix: accessibility modal close button accordion accessibility controls(ACC-21) * fix: remove duplicate entry for translation(ACC-21) * Update src/script/components/TextInput/TextInput.tsx Co-authored-by: Thomas Belin <thomasbelin4@gmail.com> * fix: code review comments addressed(ACC-21) remove input ref forwarding to child component use isTabKey and isEnterKey util * fix: make ref and editing function optional(ACC-21) Co-authored-by: Thomas Belin <thomasbelin4@gmail.com> * chore: merge dev to acc (#13651) * chore(deps-dev): Bump typescript from 4.7.4 to 4.8.2 (#13562) * chore(deps-dev): Bump typescript from 4.7.4 to 4.8.2 Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.7.4 to 4.8.2. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v4.7.4...v4.8.2) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * fix type errors Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Thomas Belin <me@thomasbelin.fr> * chore: Fix Message components type errors (#13551) * chore: Update translations (#13580) * chore: Update translations (#13609) * chore: Align node version requirement (#13612) * chore: Cleanup unneeded koReact components (#13605) * feat: use core logout when logging out (#13616) * refactor: Avoid rerendering when using fadingScrollbars (#13617) * refactor: remove missed guests and services mapping (#13259) * feat: Integrate MLS with AVS library (#13486) * feat: Integrate MLS with AVS library * use getAllParticipantsClients * remove getQualifiedClientsByUserIds * update core * Update src/script/calling/CallingRepository.ts Co-authored-by: Thomas Belin <thomasbelin4@gmail.com> Co-authored-by: Thomas Belin <thomasbelin4@gmail.com> * chore: Remove betterer (#13620) * runfix: Improve registration validation error handling (#13621) * chore: move acc changes to dev (#13608) * runfix: address account preference page style changes acc-79 (#13423) * runfix: address changes to preferences acc-79 (#13494) * solve jumping navigation items issue * add hover states to color picker * fix: list of devices screen reader announcement (#13531) * fix: address hover and focus state of sidebar call-ui acc-80 (#13548) * set context menu to open on key down * runfix: correct focus states of toggle dots acc-81 (#13582) * runfix: apply correct styles to status buttons and bump ui-kit (#13583) * fix: webapp screen reader accessibility improvements (#13584) * feat: improve accessibility(ACC-21) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Arjita <arjitamitra3@gmail.com> Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik96@gmail.com> Co-authored-by: Timothy LeBon <tlebon@gmail.com> Co-authored-by: Adrian Weiß <77456193+aweiss-dev@users.noreply.github.com> Co-authored-by: Amir Ghezelbash <thisisamir98@gmail.com> Co-authored-by: Otto the Bot <webapp+otto@wire.com> Co-authored-by: Sven Jost <mythsunwind@users.noreply.github.com> Co-authored-by: Thomas Belin <thomasbelin4@gmail.com> * runfix: Broader error handling for registration errors (#13623) * runfix: address left sidebar design review acc-78 (#13624) * runfix: address left sidebar design review acc-78 * address design review in folders tab * address design review for group creation modal * normalize margins for semantic tags * fix: update Entropy UI text: FS-951 * feat: Always send proteus messages as protobuf (#13626) * runfix: correct text selection and avatar bg colors acc-77 (#13625) * runfix: correct text selection color acc-77 * correct avatar border and bg colors * feat: update keys periodically (FS-562) (#13607) * feat: add storage table for last key material update dates * feat: add keying material update threshold time configuration env * chore: bump core version * chore: update localization strings and add semantic html in preferences acc-79 (#13619) * chore: add paragraph tags in account preferences acc-24 * update localization strings * add semantic html tags * runfix: Revert Always send proteus messages as protobuf (#13628) This reverts commit eeb3158. * chore(deps): Bump @wireapp/react-ui-kit from 8.13.7 to 8.13.8 (#13631) Bumps [@wireapp/react-ui-kit](https://github.com/wireapp/wire-web-packages) from 8.13.7 to 8.13.8. - [Release notes](https://github.com/wireapp/wire-web-packages/releases) - [Commits](https://github.com/wireapp/wire-web-packages/compare/@wireapp/react-ui-kit@8.13.7...@wireapp/react-ui-kit@8.13.8) --- updated-dependencies: - dependency-name: "@wireapp/react-ui-kit" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump @types/react from 18.0.18 to 18.0.19 (#13633) Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 18.0.18 to 18.0.19. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: "@types/react" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump typescript from 4.8.2 to 4.8.3 in /server (#13630) Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.8.2 to 4.8.3. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v4.8.2...v4.8.3) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump @typescript-eslint/eslint-plugin (#13632) Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.36.1 to 5.36.2. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.36.2/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump @babel/core from 7.18.13 to 7.19.0 (#13636) Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.18.13 to 7.19.0. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.19.0/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump @babel/plugin-proposal-decorators (#13634) Bumps [@babel/plugin-proposal-decorators](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-proposal-decorators) from 7.18.10 to 7.19.0. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.19.0/packages/babel-plugin-proposal-decorators) --- updated-dependencies: - dependency-name: "@babel/plugin-proposal-decorators" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump simple-git from 3.13.0 to 3.14.0 (#13641) Bumps [simple-git](https://github.com/steveukx/git-js/tree/HEAD/simple-git) from 3.13.0 to 3.14.0. - [Release notes](https://github.com/steveukx/git-js/releases) - [Changelog](https://github.com/steveukx/git-js/blob/main/simple-git/CHANGELOG.md) - [Commits](https://github.com/steveukx/git-js/commits/simple-git@3.14.0/simple-git) --- updated-dependencies: - dependency-name: simple-git dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump concurrently from 7.3.0 to 7.4.0 (#13640) Bumps [concurrently](https://github.com/open-cli-tools/concurrently) from 7.3.0 to 7.4.0. - [Release notes](https://github.com/open-cli-tools/concurrently/releases) - [Commits](open-cli-tools/concurrently@v7.3.0...v7.4.0) --- updated-dependencies: - dependency-name: concurrently dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump typescript from 4.8.2 to 4.8.3 (#13644) Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.8.2 to 4.8.3. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v4.8.2...v4.8.3) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump @testing-library/react from 13.3.0 to 13.4.0 (#13645) Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 13.3.0 to 13.4.0. - [Release notes](https://github.com/testing-library/react-testing-library/releases) - [Changelog](https://github.com/testing-library/react-testing-library/blob/main/CHANGELOG.md) - [Commits](testing-library/react-testing-library@v13.3.0...v13.4.0) --- updated-dependencies: - dependency-name: "@testing-library/react" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): Bump react-intl from 6.1.0 to 6.1.1 (#13646) Bumps [react-intl](https://github.com/formatjs/formatjs) from 6.1.0 to 6.1.1. - [Release notes](https://github.com/formatjs/formatjs/releases) - [Commits](https://github.com/formatjs/formatjs/compare/react-intl@6.1.0...react-intl@6.1.1) --- updated-dependencies: - dependency-name: react-intl dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump @babel/preset-env from 7.18.10 to 7.19.0 (#13639) Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.18.10 to 7.19.0. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.19.0/packages/babel-preset-env) --- updated-dependencies: - dependency-name: "@babel/preset-env" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: Update translations (#13622) * chore(deps-dev): Bump @typescript-eslint/parser from 5.36.1 to 5.36.2 (#13638) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.36.1 to 5.36.2. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.36.2/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump eslint-plugin-jest from 26.8.5 to 27.0.4 (#13642) * chore(deps-dev): Bump eslint-plugin-jest from 26.8.5 to 27.0.4 Bumps [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) from 26.8.5 to 27.0.4. - [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases) - [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md) - [Commits](jest-community/eslint-plugin-jest@v26.8.5...v27.0.4) --- updated-dependencies: - dependency-name: eslint-plugin-jest dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * lint Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Thomas Belin <me@thomasbelin.fr> * chore(deps-dev): Bump cspell from 5.20.0 to 6.8.1 (#13555) Bumps [cspell](https://github.com/streetsidesoftware/cspell) from 5.20.0 to 6.8.1. - [Release notes](https://github.com/streetsidesoftware/cspell/releases) - [Changelog](https://github.com/streetsidesoftware/cspell/blob/main/CHANGELOG.md) - [Commits](streetsidesoftware/cspell@v5.20.0...v6.8.1) --- updated-dependencies: - dependency-name: cspell dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump @types/jsdom from 16.2.14 to 20.0.0 (#13386) Bumps [@types/jsdom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jsdom) from 16.2.14 to 20.0.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jsdom) --- updated-dependencies: - dependency-name: "@types/jsdom" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump sinon from 13.0.2 to 14.0.0 (#12985) Bumps [sinon](https://github.com/sinonjs/sinon) from 13.0.2 to 14.0.0. - [Release notes](https://github.com/sinonjs/sinon/releases) - [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md) - [Commits](sinonjs/sinon@v13.0.2...v14.0.0) --- updated-dependencies: - dependency-name: sinon dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump fake-indexeddb from 3.1.8 to 4.0.0 (#13295) Bumps [fake-indexeddb](https://github.com/dumbmatter/fakeIndexedDB) from 3.1.8 to 4.0.0. - [Release notes](https://github.com/dumbmatter/fakeIndexedDB/releases) - [Changelog](https://github.com/dumbmatter/fakeIndexedDB/blob/master/CHANGELOG.md) - [Commits](dumbmatter/fakeIndexedDB@v3.1.8...v4.0.0) --- updated-dependencies: - dependency-name: fake-indexeddb dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump eslint-plugin-react from 7.31.1 to 7.31.8 (#13637) * chore(deps-dev): Bump eslint-plugin-react from 7.31.1 to 7.31.8 Bumps [eslint-plugin-react](https://github.com/jsx-eslint/eslint-plugin-react) from 7.31.1 to 7.31.8. - [Release notes](https://github.com/jsx-eslint/eslint-plugin-react/releases) - [Changelog](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/CHANGELOG.md) - [Commits](jsx-eslint/eslint-plugin-react@v7.31.1...v7.31.8) --- updated-dependencies: - dependency-name: eslint-plugin-react dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * fix config Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Thomas Belin <me@thomasbelin.fr> * chore(deps): Bump zustand from 3.7.2 to 4.1.1 (#13560) Bumps [zustand](https://github.com/pmndrs/zustand) from 3.7.2 to 4.1.1. - [Release notes](https://github.com/pmndrs/zustand/releases) - [Commits](pmndrs/zustand@v3.7.2...v4.1.1) --- updated-dependencies: - dependency-name: zustand dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump i18next-scanner from 3.3.0 to 4.0.0 (#13329) Bumps [i18next-scanner](https://github.com/i18next/i18next-scanner) from 3.3.0 to 4.0.0. - [Release notes](https://github.com/i18next/i18next-scanner/releases) - [Commits](i18next/i18next-scanner@v3.3.0...v4.0.0) --- updated-dependencies: - dependency-name: i18next-scanner dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump @faker-js/faker from 6.3.1 to 7.5.0 (#13588) * chore(deps-dev): Bump lint-staged from 12.4.2 to 13.0.3 (#13247) Bumps [lint-staged](https://github.com/okonet/lint-staged) from 12.4.2 to 13.0.3. - [Release notes](https://github.com/okonet/lint-staged/releases) - [Commits](lint-staged/lint-staged@v12.4.2...v13.0.3) --- updated-dependencies: - dependency-name: lint-staged dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * runfix: Fix tracking calling events (#13648) * chore: bump core version (#13649) * chore: deploy dev build to edge environment (#13650) * commit yarn.lock * resolve merge conflicts Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Thomas Belin <me@thomasbelin.fr> Co-authored-by: Thomas Belin <thomasbelin4@gmail.com> Co-authored-by: Otto the Bot <webapp+otto@wire.com> Co-authored-by: Timothy LeBon <tlebon@gmail.com> Co-authored-by: Amir Ghezelbash <thisisamir98@gmail.com> Co-authored-by: Arjita <arjitamitra3@gmail.com> Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik96@gmail.com> Co-authored-by: Adrian Weiß <77456193+aweiss-dev@users.noreply.github.com> Co-authored-by: Sven Jost <mythsunwind@users.noreply.github.com> Co-authored-by: Rohan Mahy <rohan.mahy@wire.com> Co-authored-by: rohan-wire <91096103+rohan-wire@users.noreply.github.com> Co-authored-by: Patryk Górka <patrykbunix@gmail.com> * runfix: address input bar design review acc-77 (#13658) * runfix: correct focus outline of button group acc-77 * replace gif button by ui-kit icon button * add active, focus and hover state to sen button * refactor: correct wrong font sizes acc-60 (#13673) * runfix: use accent color for self mention acc-155 (#13693) * fix: getServiceFromUser doesn't work properly (#13706) * fix: getServiceFromUser doesn't work properly * return value * feat: add media queries breakpoint to preferences content acc-64 (#13710) * feat: add media queries breakpoint to preferences content * restore commented out code, add variable for min screen size * adjust breakpoints to requirements and ui-kit breakpoints * feat: add responsivity to conversation view acc-63 (#13717) * feat: add media query breakpoint to input bar * address position of control buttons in scaled view * isolate giphy button in a different component * add giphy button to responsive view * add responsive size to control buttons * add breakpoints for displaying titlebar buttons * add breakpoints for timestamp width * display timestamps as column in scaled view * rename onGifClick prop for consistency * remove unused InputBarControls component * refactor reused components and props inti variables * reinstate ControlButtons test * add test for titlebar responsive view * rename center-column class to avoid duplicates * restore core-crypto * refactor: Migrate WarningsViewModel to React (#13748) * refactor: Migrate WarningsViewModel to React * error message from zustand * prepare object and check by content?.currentType * onBgClick * have duplicated ids * secondary actions * filter null actions * simplify * map * alreadyOpen * change name to primary modal * fix tests * first step to delete amplify * step 2 of deleting amplify * move to index * fix import errors * default values * use react testing library * update yarn.lock * runfix: Do not use usePrimaryModalState hook in a function (#13784) * refactor: Migrate Conversation to React (#13528) * refactor: Migrate Conversation to React * create context * Migrate conversation to react * Move code from index to Conversation * cr fixes * Fix types * revert showConversation * Test fixes * Update tests * CR Fixes * cr fixes * Cr fixes * refactor: Move WarningsContainer to Zustand (#13790) * refactor: Move WarningsContainer to Zustand * add tests * refactor: migrate right-sidebar-to-react (#13613) * refactor: Migrate ConversationDetails component to React (#ACC-258) * cr fixes * prepare fixes * cr fixes * Add TODO messages * refactor: migrate right-sidebar-to-react * refactor: migrate Guest and Services Options to React (#13618) * refactor: migrate Guest and Services Options to React * Prepare tests for guest options * Remove unecessary code * refactor: migrate GroupParticipantService to react (#13615) * refactor: migrate GroupParticipantService to react * update group participant service * refactor: migrate AddParticipants to React (#13614) * refactor: migrate AddParticipants to React * Replace useCallback with useMemo * refactor: migrate message-details to react (#13704) * Migrate message details * CR fixes * refactor: migrate conversation participants to react (#13606) * refactor: migrate ConversationParticipants to React (#ACC-269) * Migrate conversation participants * Fix for 400 error * change number of max visible users * right-sidebar changes * Right panel animations * CR changes * Cr changes * Cr changes * Fix tests * build fixes * cr fixes * Fixes * undo contentViewModel variables * change animation time * replace contentViewModel states with enum * runfix: Correctly stack modals and fix memory issue in renderElement (#13803) * runfix: Correctly stack modals and fix memory issue in renderElement * use Map * fix: fix tests and remove unnecessary code (#13804) * fix: fix tests and remove unecessary code * remove amplify from giphy * CR Fixes * runfix: Correctly handle primary modals secondary action (#13811) * fix: [Web] Spacebar does not work on checkboxes while adding participants to a group(ACC-280) (#13814) * feat: Migrate Legal Hold Modal to React (ACC-197) (#13313) * Migrate legal hold modal to react * Write basic tests * Fixes * cr fixes * cr fixes * update tests * legal hold modal fixes * chore: eslint improvements (#13806) * feat: update eslint and fix all errors * feat: add linter rules and fix all critical bugs / errors * feat: add circular dependency check * chore: print tree and warnings for circular * chore: fix lint-staged * chore: set jsx-a11y/no-noninteractive-tabindex to warn * Merge remote-tracking branch origin/acc into chore/eslint-improvements * chore: disable react/react-in-jsx-scope * runfix: Add onChange handler to inputs in primary modal (#13839) * chore: refine wire configuration - type (#13843) * chore: split up wire types * chore: rename type * refactor: migrate knockout wire-main to react (#13845) * runfix: Use primary modals directly in jsx (#13846) * runfix: Use primary modals directly in jsx * remove log * runfix: Correctly show error message in delete device modal (#13847) * runfix: RightSidebar deflake tests (#13851) * runfix: RightSidebar deflake tests * remove unecessary code * runfix: fix white screen when navigate in RightSidebar (#13856) * chore: work on linter warnings (#13852) * chore: fix rule "no default export" * chore: wrap up imports * chore: fix unit tests * runfix: Close Right Sidebar on application actions (#13858) * chore: activate no-magic-numbers rule * runfix: Deflake test for RightSidebar (#13859) * runfix: Close Right Sidebar on application actions * runfix: Deflake test for RightSidebar * feat: implement collapsing left sidebar acc-62 (#13791) * feat: add state management for responsive views * commit zustand store * implement collapsing sidebar in conversation view * implement collapsing sidebar in preferences view * experiment with breakpoints * resolve merge conflicts * add min height to list elements to insure scrolling at extreme zoom level * add brealpoint to titlebar * fix merge errors * complete merge of titlebar component * remove superfluous instances of StyledApp * add close button to preferences in scaled down view * correct straggler merge error * correct behavior of changing responsive states in preferences * remove need for css classes for collapsing left sidebar * move responsive view state management to AppMainState * center left sidebar title * refactor useAppMainState hook in react components * refactor function call from the root of routerBinding * add comment about breakpoints magic numbers * wrap Device Preference component in the correct PreferencePage wrapper * fix tests * Apply suggestions from code review Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik96@gmail.com> * address code review * address code review Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik96@gmail.com> * refactor: Move LegalHoldModal to zustand (#13883) * fixes * refactor: Move LegalHoldModal to zustand * restore previous code * runfix: TextInput and nth-child tests (#13884) * runfix: Open LegalHoldModal on show request (#13888) * runfix: Open LegalHoldModal on show request * Update src/script/components/Modals/LegalHoldModal/LegalHoldModal.state.ts Co-authored-by: Thomas Belin <thomasbelin4@gmail.com> * cr fixes Co-authored-by: Thomas Belin <thomasbelin4@gmail.com> * runfix: prevent sidebar header to overlap with button (#13889) * runfix: prevent sidebar header to overlap with button * runfix: prvent overflow for av select at minimum screen width (#13891) * runfix: address responsive design in authentication screen [ACC-66] (#13894) * runfix: show back arrow and margin on mobile breakpoint * apply correct design to links * center wire logo * runfix: Open user details on avatar click (#13890) * feat: scaled down view for call-ui [ACC-65] (#13881) * feat: add responsive breakpoints to call-ui * implement back button to scaled down call ui * remove pagination dots from responsiive view * address cr * Update src/script/components/calling/FullscreenVideoCall.tsx Co-authored-by: Timothy LeBon <tlebon@gmail.com> * fix tests Co-authored-by: Timothy LeBon <tlebon@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Timothy LeBon <tlebon@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik96@gmail.com> Co-authored-by: Virgile <78490891+V-Gira@users.noreply.github.com> Co-authored-by: Arjita <arjitamitra3@gmail.com> Co-authored-by: Amir Ghezelbash <thisisamir98@gmail.com> Co-authored-by: Otto the Bot <webapp+otto@wire.com> Co-authored-by: Sven Jost <mythsunwind@users.noreply.github.com> Co-authored-by: Thomas Belin <thomasbelin4@gmail.com> Co-authored-by: Thomas Belin <me@thomasbelin.fr> Co-authored-by: Rohan Mahy <rohan.mahy@wire.com> Co-authored-by: rohan-wire <91096103+rohan-wire@users.noreply.github.com> Co-authored-by: Patryk Górka <patrykbunix@gmail.com>

refactor: Migrate WarningsViewModel to React

30c8571

thisisamir98 requested review from a team and otto-the-bot as code owners September 28, 2022 13:24

otto-the-bot added comp: calling comp: preferences type: refactoring 🛠 👕 size: XXL labels Sep 28, 2022

error message from zustand

a1197f0

przemvs requested changes Sep 28, 2022

View reviewed changes

thisisamir98 added 12 commits September 29, 2022 13:48

prepare object and check by content?.currentType

f209919

onBgClick

f675f8f

have duplicated ids

73ad785

secondary actions

82daa9b

filter null actions

5e8b045

simplify

4bc2634

map

11a7af4

alreadyOpen

e6c5dd8

change name to primary modal

02547a5

fix tests

22849af

first step to delete amplify

fe44777

step 2 of deleting amplify

342f8a0

V-Gira reviewed Sep 29, 2022

View reviewed changes

atomrc reviewed Sep 29, 2022

View reviewed changes

przemvs requested changes Sep 29, 2022

View reviewed changes

move to index

95d5421

thisisamir98 added 2 commits October 3, 2022 12:31

fix import errors

0c6c7b3

default values

e44182b

atomrc reviewed Oct 3, 2022

View reviewed changes

przemvs approved these changes Oct 3, 2022

View reviewed changes

thisisamir98 force-pushed the refactor-warnings-modals-to-react branch from 745488c to e44182b Compare October 3, 2022 10:33

thisisamir98 added 2 commits October 3, 2022 14:04

Merge branch 'acc' into refactor-warnings-modals-to-react

1d44efd

use react testing library

b773820

atomrc approved these changes Oct 3, 2022

View reviewed changes

PatrykBuniX approved these changes Oct 3, 2022

View reviewed changes

thisisamir98 merged commit 2e7cfcf into acc Oct 3, 2022

thisisamir98 deleted the refactor-warnings-modals-to-react branch October 3, 2022 13:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Migrate WarningsViewModel to React #13748

refactor: Migrate WarningsViewModel to React #13748

thisisamir98 commented Sep 28, 2022

codecov bot commented Sep 28, 2022 •

edited

przemvs left a comment

V-Gira left a comment

atomrc Sep 29, 2022

atomrc Sep 29, 2022

atomrc Sep 29, 2022

atomrc Sep 29, 2022

atomrc Sep 29, 2022

przemvs left a comment

przemvs Sep 29, 2022

przemvs Sep 29, 2022

przemvs Sep 29, 2022

thisisamir98 Oct 3, 2022

przemvs Sep 29, 2022

przemvs Sep 29, 2022

przemvs Sep 29, 2022

przemvs Sep 29, 2022

przemvs Sep 29, 2022

przemvs Sep 29, 2022

przemvs Sep 29, 2022

atomrc Oct 3, 2022

przemvs left a comment

PatrykBuniX left a comment

	onClick={() => action?.action && doAction(action?.action, true, true)}
	onClick={() => action?.action && doAction(action.action, true, true)}

refactor: Migrate WarningsViewModel to React #13748

refactor: Migrate WarningsViewModel to React #13748

Conversation

thisisamir98 commented Sep 28, 2022

codecov bot commented Sep 28, 2022 • edited

Codecov Report

przemvs left a comment

Choose a reason for hiding this comment

V-Gira left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

przemvs left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

przemvs left a comment

Choose a reason for hiding this comment

PatrykBuniX left a comment

Choose a reason for hiding this comment

codecov bot commented Sep 28, 2022 •

edited