-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runfix: fix codeblock link parsing (FS-1066) #13857
Conversation
@@ -71,28 +71,6 @@ markdownit.renderer.rules.paragraph_open = (tokens, idx) => { | |||
}; | |||
markdownit.renderer.rules.paragraph_close = () => ''; | |||
|
|||
// https://github.com/markdown-it/markdown-it/issues/458#issuecomment-401221267 | |||
function modifyMarkdownLinks(markdown: string): string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
library has already fixed links with underscore
Codecov Report
@@ Coverage Diff @@
## dev #13857 +/- ##
==========================================
- Coverage 39.18% 39.14% -0.05%
==========================================
Files 568 568
Lines 21083 21067 -16
Branches 4556 4551 -5
==========================================
- Hits 8262 8246 -16
Misses 11824 11824
Partials 997 997 |
expect(renderMessage(`[sometext](https://some.domain"><script>alert("oops")</script>)`)).toBe( | ||
`[sometext](<a href="https://some.domain" target="_blank" rel="nofollow noopener noreferrer">https://some.domain</a>"><script>alert("oops")</script>)`, | ||
`<a href=\"https://some.domain%22%3E%3Cscript%3Ealert(%22oops%22)%3C/script%3E\" target=\"_blank\" rel=\"nofollow noopener noreferrer\" data-md-link=\"true\" data-uie-name=\"markdown-link\">sometext</a>`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look like a vulnerability to me, since this link is not valid anyway (try pasting it in search bar), wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PatrykBuniX Indeed, the intention here is to make sure, that the "injected" html code does not end up in the resulting html.
both (old and new) test results are valid here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
* runfix: fix codeblock link parsing * test: fix test * chore: update test name * test: add 2 test cases
* runfix: fix codeblock link parsing * test: fix test * chore: update test name * test: add 2 test cases
* chore: Bump application version * refactor: factorize login buttons (#13813) * chore: fix types * chore(deps): Bump crowdin/github-action from 1.4.14 to 1.4.15 (#13886) Bumps [crowdin/github-action](https://github.com/crowdin/github-action) from 1.4.14 to 1.4.15. - [Release notes](https://github.com/crowdin/github-action/releases) - [Commits](crowdin/github-action@1.4.14...1.4.15) --- updated-dependencies: - dependency-name: crowdin/github-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): Bump amannn/action-semantic-pull-request (#13885) Bumps [amannn/action-semantic-pull-request](https://github.com/amannn/action-semantic-pull-request) from 5.0.1 to 5.0.2. - [Release notes](https://github.com/amannn/action-semantic-pull-request/releases) - [Changelog](https://github.com/amannn/action-semantic-pull-request/blob/main/CHANGELOG.md) - [Commits](amannn/action-semantic-pull-request@v5.0.1...v5.0.2) --- updated-dependencies: - dependency-name: amannn/action-semantic-pull-request dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: Upgrade @wireapp/core (#13887) This will provide better logs for MLS specific messages * fix: update core to get rid of the missing messages message bug (#13892) * chore: Cleanup unused dependencies (#13893) * chore: replace discontinued postcss-cssnext with postcss-preset-env (#13895) * fix: use hasOwnProperty instead of direct object access (#13896) This verifies that an externally controlled value can only be set to defined entries in `actions` and will otherwise return with an error. * feat: Get Sender client ID from CoreCrypto to pass to AVS (FS-1045) (#13897) * feat: Get Sender client ID from CoreCrypto to pass to AVS (FS-1045) * change name * update deps * runfix: fix codeblock link parsing (FS-1066) (#13857) * runfix: fix codeblock link parsing * test: fix test * chore: update test name * test: add 2 test cases * feat: add ENABLE_DEV_BACKEND_API env variable [FS-1051] (#13912) * feat: add ENABLE_DEV_BACKEND_API env variable * runfix: apply new core changes * chore: add ENABLE_DEV_BACKEND_API to localhost env file with value of true * refactor: Move cryptobox hooks into @wireapp/core (#13905) * feat: activate mls for client via mls feature config [FS-1088] (#13898) * feat: always pass mlsconfig object to initialize mlsclient * feat: enable sending external proposals when mls feature flag is off * runfix: add support for broken clients by disabling mls for them * refactor: update var name * chore: bump core to use renamed systemCrypto * chore: use exact version match * chore: update lock file * refactor: rename disabling mls helper boolean * refactor: simplify supportmls logic * runfix: require feature flag to support mls for m4 * runfix: make supportMLS a function * Revert "runfix: make supportMLS a function" This reverts commit 06ba72d. * Revert "runfix: require feature flag to support mls for m4" This reverts commit a32154e. * runfix: add mls feature config var back to supportMLS helper * runfix: fix for firefox ephemeral message progress icon (#13919) * chore(deps-dev): Bump @babel/plugin-proposal-decorators (#13930) Bumps [@babel/plugin-proposal-decorators](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-proposal-decorators) from 7.19.3 to 7.19.6. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.19.6/packages/babel-plugin-proposal-decorators) --- updated-dependencies: - dependency-name: "@babel/plugin-proposal-decorators" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): Bump @wireapp/core from 34.0.2 to 34.1.1 (#13926) Bumps [@wireapp/core](https://github.com/wireapp/wire-web-packages) from 34.0.2 to 34.1.1. - [Release notes](https://github.com/wireapp/wire-web-packages/releases) - [Commits](https://github.com/wireapp/wire-web-packages/compare/@wireapp/core@34.0.2...@wireapp/core@34.1.1) --- updated-dependencies: - dependency-name: "@wireapp/core" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): Bump @wireapp/store-engine-dexie from 1.7.6 to 1.7.11 (#13931) Bumps [@wireapp/store-engine-dexie](https://github.com/wireapp/wire-web-packages) from 1.7.6 to 1.7.11. - [Release notes](https://github.com/wireapp/wire-web-packages/releases) - [Commits](https://github.com/wireapp/wire-web-packages/compare/@wireapp/store-engine-dexie@1.7.6...@wireapp/store-engine-dexie@1.7.11) --- updated-dependencies: - dependency-name: "@wireapp/store-engine-dexie" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump jest-environment-jsdom from 29.1.2 to 29.2.1 (#13932) Bumps [jest-environment-jsdom](https://github.com/facebook/jest/tree/HEAD/packages/jest-environment-jsdom) from 29.1.2 to 29.2.1. - [Release notes](https://github.com/facebook/jest/releases) - [Changelog](https://github.com/facebook/jest/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/jest/commits/v29.2.1/packages/jest-environment-jsdom) --- updated-dependencies: - dependency-name: jest-environment-jsdom dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): Bump react-intl from 6.2.0 to 6.2.1 (#13927) Bumps [react-intl](https://github.com/formatjs/formatjs) from 6.2.0 to 6.2.1. - [Release notes](https://github.com/formatjs/formatjs/releases) - [Commits](https://github.com/formatjs/formatjs/compare/react-intl@6.2.0...react-intl@6.2.1) --- updated-dependencies: - dependency-name: react-intl dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): Bump @wireapp/commons from 4.4.6 to 4.4.10 in /server (#13928) Bumps [@wireapp/commons](https://github.com/wireapp/wire-web-packages) from 4.4.6 to 4.4.10. - [Release notes](https://github.com/wireapp/wire-web-packages/releases) - [Commits](https://github.com/wireapp/wire-web-packages/compare/@wireapp/commons@4.4.6...@wireapp/commons@4.4.10) --- updated-dependencies: - dependency-name: "@wireapp/commons" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump eslint-plugin-jest from 27.1.2 to 27.1.3 (#13936) Bumps [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) from 27.1.2 to 27.1.3. - [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases) - [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md) - [Commits](jest-community/eslint-plugin-jest@v27.1.2...v27.1.3) --- updated-dependencies: - dependency-name: eslint-plugin-jest dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump @wireapp/prettier-config from 0.4.6 to 0.4.7 (#13933) Bumps [@wireapp/prettier-config](https://github.com/wireapp/wire-web-packages) from 0.4.6 to 0.4.7. - [Release notes](https://github.com/wireapp/wire-web-packages/releases) - [Commits](https://github.com/wireapp/wire-web-packages/compare/@wireapp/prettier-config@0.4.6...@wireapp/prettier-config@0.4.7) --- updated-dependencies: - dependency-name: "@wireapp/prettier-config" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump @babel/core from 7.19.3 to 7.19.6 (#13939) Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.19.3 to 7.19.6. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.19.6/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): Bump @wireapp/webapp-events from 0.14.6 to 0.14.9 (#13937) Bumps [@wireapp/webapp-events](https://github.com/wireapp/wire-web-packages) from 0.14.6 to 0.14.9. - [Release notes](https://github.com/wireapp/wire-web-packages/releases) - [Commits](https://github.com/wireapp/wire-web-packages/compare/@wireapp/webapp-events@0.14.6...@wireapp/webapp-events@0.14.9) --- updated-dependencies: - dependency-name: "@wireapp/webapp-events" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump @types/node from 18.11.0 to 18.11.3 (#13940) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 18.11.0 to 18.11.3. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump concurrently from 7.4.0 to 7.5.0 (#13935) Bumps [concurrently](https://github.com/open-cli-tools/concurrently) from 7.4.0 to 7.5.0. - [Release notes](https://github.com/open-cli-tools/concurrently/releases) - [Commits](open-cli-tools/concurrently@v7.4.0...v7.5.0) --- updated-dependencies: - dependency-name: concurrently dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump @typescript-eslint/parser from 5.40.0 to 5.40.1 (#13943) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.40.0 to 5.40.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.40.1/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): Bump zustand from 4.1.2 to 4.1.3 (#13946) Bumps [zustand](https://github.com/pmndrs/zustand) from 4.1.2 to 4.1.3. - [Release notes](https://github.com/pmndrs/zustand/releases) - [Commits](pmndrs/zustand@v4.1.2...v4.1.3) --- updated-dependencies: - dependency-name: zustand dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump eslint from 8.25.0 to 8.26.0 (#13938) Bumps [eslint](https://github.com/eslint/eslint) from 8.25.0 to 8.26.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.25.0...v8.26.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump caniuse-lite from 1.0.30001420 to 1.0.30001423 (#13947) Bumps [caniuse-lite](https://github.com/browserslist/caniuse-lite) from 1.0.30001420 to 1.0.30001423. - [Release notes](https://github.com/browserslist/caniuse-lite/releases) - [Commits](browserslist/caniuse-lite@1.0.30001420...1.0.30001423) --- updated-dependencies: - dependency-name: caniuse-lite dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump jest and @types/jest (#13929) Bumps [jest](https://github.com/facebook/jest/tree/HEAD/packages/jest) and [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest). These dependencies needed to be updated together. Updates `jest` from 29.2.0 to 29.2.1 - [Release notes](https://github.com/facebook/jest/releases) - [Changelog](https://github.com/facebook/jest/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/jest/commits/v29.2.1/packages/jest) Updates `@types/jest` from 29.1.2 to 29.2.0 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest) --- updated-dependencies: - dependency-name: jest dependency-type: direct:development update-type: version-update:semver-patch - dependency-name: "@types/jest" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump @wireapp/copy-config from 1.3.6 to 1.3.10 (#13941) Bumps [@wireapp/copy-config](https://github.com/wireapp/wire-web-packages) from 1.3.6 to 1.3.10. - [Release notes](https://github.com/wireapp/wire-web-packages/releases) - [Commits](https://github.com/wireapp/wire-web-packages/compare/@wireapp/copy-config@1.3.6...@wireapp/copy-config@1.3.10) --- updated-dependencies: - dependency-name: "@wireapp/copy-config" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump @typescript-eslint/eslint-plugin (#13948) Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.40.0 to 5.40.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.40.1/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): Bump @wireapp/react-ui-kit from 8.17.0 to 8.17.5 (#13949) Bumps [@wireapp/react-ui-kit](https://github.com/wireapp/wire-web-packages) from 8.17.0 to 8.17.5. - [Release notes](https://github.com/wireapp/wire-web-packages/releases) - [Commits](https://github.com/wireapp/wire-web-packages/compare/@wireapp/react-ui-kit@8.17.0...@wireapp/react-ui-kit@8.17.5) --- updated-dependencies: - dependency-name: "@wireapp/react-ui-kit" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): Bump @wireapp/store-engine-sqleet from 1.8.6 to 1.8.9 (#13934) Bumps [@wireapp/store-engine-sqleet](https://github.com/wireapp/wire-web-packages) from 1.8.6 to 1.8.9. - [Release notes](https://github.com/wireapp/wire-web-packages/releases) - [Commits](https://github.com/wireapp/wire-web-packages/compare/@wireapp/store-engine-sqleet@1.8.6...@wireapp/store-engine-sqleet@1.8.9) --- updated-dependencies: - dependency-name: "@wireapp/store-engine-sqleet" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump eslint-plugin-jsdoc from 39.3.6 to 39.3.21 (#13950) Bumps [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) from 39.3.6 to 39.3.21. - [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases) - [Commits](gajus/eslint-plugin-jsdoc@v39.3.6...v39.3.21) --- updated-dependencies: - dependency-name: eslint-plugin-jsdoc dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump jest-jasmine2 from 29.2.0 to 29.2.1 (#13942) Bumps [jest-jasmine2](https://github.com/facebook/jest/tree/HEAD/packages/jest-jasmine2) from 29.2.0 to 29.2.1. - [Release notes](https://github.com/facebook/jest/releases) - [Changelog](https://github.com/facebook/jest/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/jest/commits/v29.2.1/packages/jest-jasmine2) --- updated-dependencies: - dependency-name: jest-jasmine2 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump @wireapp/eslint-config from 1.12.11 to 1.12.12 (#13944) Bumps [@wireapp/eslint-config](https://github.com/wireapp/wire-web-packages) from 1.12.11 to 1.12.12. - [Release notes](https://github.com/wireapp/wire-web-packages/releases) - [Commits](https://github.com/wireapp/wire-web-packages/compare/@wireapp/eslint-config@1.12.11...@wireapp/eslint-config@1.12.12) --- updated-dependencies: - dependency-name: "@wireapp/eslint-config" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump @formatjs/cli from 5.1.2 to 5.1.3 (#13945) Bumps [@formatjs/cli](https://github.com/formatjs/formatjs) from 5.1.2 to 5.1.3. - [Release notes](https://github.com/formatjs/formatjs/releases) - [Commits](https://github.com/formatjs/formatjs/compare/@formatjs/cli@5.1.2...@formatjs/cli@5.1.3) --- updated-dependencies: - dependency-name: "@formatjs/cli" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * runfix: show expand option for collections over limit [FS-1025] (#13921) * runfix: show expand option for collections over limit * test: CollectionSection component * test: fix tests * refactor: apply cr suggestions * refactor: cr changes * chore: Upgrade @wireapp/core (#13951) * chore: bump used versions of minimatch (#13952) * chore(deps): Bump crowdin/github-action from 1.4.15 to 1.4.16 (#13925) * chore(deps): Bump wire-web-config-default-staging in /app-config (#13917) Bumps [wire-web-config-default-staging](https://github.com/wireapp/wire-web-config-default) from v0.31.4 to v0.31.8. - [Release notes](https://github.com/wireapp/wire-web-config-default/releases) - [Commits](wireapp/wire-web-config-default@v0.31.4...195c8e4) --- updated-dependencies: - dependency-name: wire-web-config-default-staging dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * refactor: Use @wireapp/core for generating fingerprints [FS-1101] (#13918) * Revert "chore(deps): Bump cakeinpanic/jira-description-action from 0.3.2 to 1.2 (#12865)" (#13953) This reverts commit 4678e30. * chore(deps): Bump wire-web-config-default-master in /app-config (#13916) * chore: Add docker image generation job (#13954) * chore: Fix docker image creation job * chore: More docker image build fix * runfix: audio file previews don't match on sender and receiver side (#13958) * runfix: Pass messageId when creating message edit (#13961) This allows the linkPreview system to overwrite the message in case a link preview comes in * chore: upgrade @wireapp/core (#13962) * chore: Simplify babel config (#13963) * chore: set port to 0.0.0.0 * fix: update react-ui-kit to apply font weight fix (#13967) * refactor: correct colors in dark mode [ACC-61] (#13675) * refactor: correct colors in dark mode acc-61 * remove fade on css var * add css variable to mixins * runfix: enable sending the same asset multiple times in a row (#13966) * runfix: enable sending the same asset multiple times in a row * refactor: move AssetUploadButton to separate component and reset file input by rerendering * test: AssetUploadButton component test * refactor: wrap upload button with form to reset it easily after upload * runfix: upgrade @wireapp/core for mls client comparison fix * runfix: upload same image multiple times (#13969) * runfix: wrapp image upload button with form and move it to separate file * test: add ImageUploadButton component test * refactor: organize directory structure in page folder * refactor: reorganise folder structure * chore: Improve jest-github integration (#13970) * fix: Upgrade @wireapp/core (#13973) * chore: update wire-web-app packages with breaking changes (#13975) * chore: update wire-web-app packages with breaking changes * chore: remove typescript linting * chore: update deps Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Arjita <arjitamitra3@gmail.com> Co-authored-by: Thomas Belin <thomasbelin4@gmail.com> Co-authored-by: Thomas Belin <me@thomasbelin.fr> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sebastian Willenborg <sebastian.willenborg@wire.com> Co-authored-by: Amir Ghezelbash <thisisamir98@gmail.com> Co-authored-by: Patryk Górka <patrykbunix@gmail.com> Co-authored-by: Virgile <78490891+V-Gira@users.noreply.github.com>
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Issue described here: #10217. Hack for supporting links with underscores introduced a small bug in codeblock links.
Causes (Optional)
In older versions of
markdown-it
library, there was a bug where links with underscores (_
) were not supported. We were using this hack as a workaround.Solutions
The
markdown-it
library seems to be supporting links with underscores now. So the solution is just removing the hack.PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.