Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent guest icon to show for federated users WPB-1987 #15341

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

V-Gira
Copy link
Contributor

@V-Gira V-Gira commented Jun 13, 2023

BugWPB-1987 There should be no guest label shown for federated users

Issue

  • users that are able to message you but were not fetched by your client (people on your contact list whose b-e was unavailable when starting a session on a new device) show up as guest
  • once user metadata has been fetched, they show up at both federated and guest and should only show up as federated

image

Solution

  • add a !isFederated check for relevant instances of the guest icon

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #15341 (b78d78d) into dev (78763ef) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##              dev   #15341   +/-   ##
=======================================
  Coverage   43.18%   43.19%           
=======================================
  Files         647      647           
  Lines       21775    21780    +5     
  Branches     5004     5007    +3     
=======================================
+ Hits         9404     9407    +3     
- Misses      11167    11168    +1     
- Partials     1204     1205    +1     

@V-Gira V-Gira merged commit fec3db7 into dev Jun 13, 2023
11 checks passed
@V-Gira V-Gira deleted the virgile/remove-guest-icon branch June 13, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants