Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update call participant video state when changed [WPB-2494] #15421

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

PatrykBuniX
Copy link
Contributor

@PatrykBuniX PatrykBuniX commented Jul 3, 2023

BugWPB-2494 [Web] Video stream not displayed anymore when leaving and rejoining a call while video is received

Fixes the issue where video/screenshare of other call participants is not visible after rejoining the call.

We initialise call participants with video state 0 (STOPPED). Previously we were just listening to videoStateChanged (vstateh) event to update videoState of participants in webapp client. When rejoining the call this callback is not really fired since video state of the other users does not really change (we're the one who's joining the call), so webapp was never informed again that some participants are sharing video/screen.

The solution is to update video state of each participant whenever participant list changes - wCall.setParticipantChangedHandler(wUser, this.handleCallParticipantChanges). This callback gets fired if any state of call participant changes - whether it is audio establishment (aestab), video state (vrecv) or muted. When joining a call user is informed of what is the current state of call participants. For more details see https://wearezeta.atlassian.net/wiki/spaces/ENGINEERIN/pages/616857724/Use+case+observe+call+participants

@PatrykBuniX PatrykBuniX changed the title fix: update call participant vide state when changed fix: update call participant vide state when changed [WPB-2494] Jul 3, 2023
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #15421 (986da69) into dev (5218339) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##              dev   #15421   +/-   ##
=======================================
  Coverage   43.34%   43.34%           
=======================================
  Files         647      647           
  Lines       21825    21826    +1     
  Branches     5016     5016           
=======================================
+ Hits         9459     9460    +1     
  Misses      11148    11148           
  Partials     1218     1218           

@PatrykBuniX PatrykBuniX marked this pull request as ready for review July 3, 2023 09:49
@PatrykBuniX PatrykBuniX requested review from a team and otto-the-bot as code owners July 3, 2023 09:49
@V-Gira V-Gira changed the title fix: update call participant vide state when changed [WPB-2494] fix: update call participant video state when changed [WPB-2494] Jul 3, 2023
@PatrykBuniX PatrykBuniX merged commit 5069ce6 into dev Jul 3, 2023
19 checks passed
@PatrykBuniX PatrykBuniX deleted the fix/WPB-2494-no-video-after-calll-rejoin branch July 3, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants