fix: prevent scrolling on user modal (WPB-4472) #15853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V-Gira
commented
Sep 19, 2023
| @@ -50,11 +50,16 @@ export const userModalStyle = css` | |||
| } | |||
|
|
|||
| .modal__body { | |||
| padding: 16px; | |||
| padding: 0 16px; | |||
There was a problem hiding this comment.
Removing the vertical padding brings us closer to the design specs
V-Gira
commented
Sep 19, 2023
|
|
||
| .classified-bar { | ||
| margin-top: 12px; | ||
| width: calc(100% + 32px); | ||
| } | ||
| } | ||
| `; | ||
|
|
||
| export const userModalWrapperStyle: CSSObject = { | ||
| maxHeight: '90vh', |
There was a problem hiding this comment.
an other option would be fit-content, 90vh allows makes it more obvious the component is a modal on smaller windows
Codecov Report
@@ Coverage Diff @@
## dev #15853 +/- ##
=======================================
Coverage 44.52% 44.52%
=======================================
Files 673 673
Lines 22727 22728 +1
Branches 5169 5169
=======================================
+ Hits 10119 10120 +1
Misses 11317 11317
Partials 1291 1291 |
PatrykBuniX
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevents unwanted scrolling on the user modal
Screenshots/Screencast (for UI changes)
Before:
After:
Checklist