-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent scrolling on user modal (WPB-4472) #15853
Conversation
@@ -50,11 +50,16 @@ export const userModalStyle = css` | |||
} | |||
|
|||
.modal__body { | |||
padding: 16px; | |||
padding: 0 16px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the vertical padding brings us closer to the design specs
|
||
.classified-bar { | ||
margin-top: 12px; | ||
width: calc(100% + 32px); | ||
} | ||
} | ||
`; | ||
|
||
export const userModalWrapperStyle: CSSObject = { | ||
maxHeight: '90vh', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## dev #15853 +/- ##
=======================================
Coverage 44.52% 44.52%
=======================================
Files 673 673
Lines 22727 22728 +1
Branches 5169 5169
=======================================
+ Hits 10119 10120 +1
Misses 11317 11317
Partials 1291 1291 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😎
Description
Prevents unwanted scrolling on the user modal
Screenshots/Screencast (for UI changes)
Before:
![image](https://private-user-images.githubusercontent.com/78490891/268988790-e8d49fa5-9b46-4d67-8d6b-10ac29edf8b8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQzMjYxMzksIm5iZiI6MTcyNDMyNTgzOSwicGF0aCI6Ii83ODQ5MDg5MS8yNjg5ODg3OTAtZThkNDlmYTUtOWI0Ni00ZDY3LThkNmItMTBhYzI5ZWRmOGI4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIyVDExMjM1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWEwYWVjMGFiNDgzOGVhNWZhYWJjZWZmOGNmNzkyZDllOGNjNDNiOWU1MzJhNmY4NTFkY2Q3NmNmNjhhMTA3NjgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.qDdGjz09ybaROESolh39yRCGg0bj-yM6sN48OKrj-0w)
After:
![Screenshot from 2023-09-19 16-20-30](https://private-user-images.githubusercontent.com/78490891/268989066-bca2b0ff-05ac-4a72-b5c2-7f951801d21f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQzMjYxMzksIm5iZiI6MTcyNDMyNTgzOSwicGF0aCI6Ii83ODQ5MDg5MS8yNjg5ODkwNjYtYmNhMmIwZmYtMDVhYy00YTcyLWI1YzItN2Y5NTE4MDFkMjFmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIyVDExMjM1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU2ZmE0ZmYyZDQ0N2U2MmFlNWMxNmQ1NDkyMDQ1ZTBjOTE4YWM2ZTAwMDU2OWYxNTNhNzIyZTQxN2UyNWQwMGQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.gu71plYy6pMMJObdjRFsPgtW6NlKWE7sEemRkPg91fI)
Checklist