feat: Reactions UI Improvements #16433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrykBuniX
reviewed
Dec 28, 2023
Comment on lines
56
to
57
| qualifiedIds={users} | ||
| conversationUsers={conversationUsers} |
There was a problem hiding this comment.
Since we're passing all the conversation users anyway, would that make sense to filter out those that have not reacted at this point? And instead of qualifiedIds pass reactionUsers list of user entitties? 🤔
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #16433 +/- ##
==========================================
- Coverage 45.53% 45.49% -0.04%
==========================================
Files 735 736 +1
Lines 24021 24110 +89
Branches 5455 5487 +32
==========================================
+ Hits 10938 10970 +32
- Misses 11686 11734 +48
- Partials 1397 1406 +9 |
atomrc
reviewed
Jan 2, 2024
| @@ -63,32 +67,67 @@ export const EmojiPill: FC<EmojiPillProps> = ({ | |||
| index, | |||
| emojiListCount, | |||
| hasUserReacted, | |||
| reactedUsers, | |||
There was a problem hiding this comment.
Suggested change
| reactedUsers, | |
| reactingUsers, |
atomrc
reviewed
Jan 2, 2024
| @@ -48,9 +49,13 @@ const MessageReactionsList: FC<MessageReactionsListProps> = ({reactions, ...prop | |||
| const emojiListCount = users.length; | |||
| const hasUserReacted = users.some(user => matchQualifiedIds(selfUserId, user)); | |||
|
|
|||
| const reactedUsers = users | |||
There was a problem hiding this comment.
Suggested change
| const reactedUsers = users | |
| const reactingUsers = users |
atomrc
reviewed
Jan 2, 2024
| transition-delay: @animation-timing-faster + 0.05; | ||
| } | ||
| } | ||
|
|
||
| // MESSAGE - ACTIONS | ||
| .message-body-actions { |
atomrc
reviewed
Jan 2, 2024
Comment on lines
116
to
118
| <span key={text} onClick={onTooltipReactionCountClick} css={messageReactionButtonTooltipTextLink}> | ||
| {text} | ||
| </span> |
There was a problem hiding this comment.
could we make this a button?
atomrc
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-5369
Description
Screenshots/Screencast (for UI changes)
Checklist
Important details for the reviewers
(Delete this section if unnecessary)