fix: handle connection requests with deleted users [WPB-4356] #16815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #16815 +/- ##
==========================================
+ Coverage 45.85% 45.86% +0.01%
==========================================
Files 746 747 +1
Lines 24440 24501 +61
Branches 5578 5594 +16
==========================================
+ Hits 11207 11238 +31
- Misses 11815 11839 +24
- Partials 1418 1424 +6 |
PatrykBuniX
changed the title
PatrykBuniX
changed the title
przemvs
approved these changes
Feb 13, 2024
atomrc
reviewed
Feb 13, 2024
| @@ -52,6 +52,7 @@ export class ConnectionRepository { | |||
| private readonly connectionService: ConnectionService; | |||
| private readonly userRepository: UserRepository; | |||
| private readonly logger: Logger; | |||
| private deleteConnectionRequestConversation?: (userId: QualifiedId) => Promise<void>; | |||
There was a problem hiding this comment.
We could probably find a naming that suggest it's a callback (here we feel it's going to trigger an imperative action)
atomrc
approved these changes
Feb 13, 2024
PatrykBuniX
deleted the
runfix/WPB-4356-deleted-profile-connection-req
branch
atomrc
pushed a commit
that referenced
this pull request
Feb 14, 2024
* runfix: filter out connection requests with deleted users * test: fix tests * runfix: handle canceling a connection req with deleted user * test: fix test * runfix: handle incoming request case * test: add scenario for deleting local req when loading conversations * test: add scenario for trying to accept/ignore incoming req * refactor: improve callback naming
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist