-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle connection requests with deleted users [WPB-4356] #16815
fix: handle connection requests with deleted users [WPB-4356] #16815
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #16815 +/- ##
==========================================
+ Coverage 45.85% 45.86% +0.01%
==========================================
Files 746 747 +1
Lines 24440 24501 +61
Branches 5578 5594 +16
==========================================
+ Hits 11207 11238 +31
- Misses 11815 11839 +24
- Partials 1418 1424 +6 |
@@ -52,6 +52,7 @@ export class ConnectionRepository { | |||
private readonly connectionService: ConnectionService; | |||
private readonly userRepository: UserRepository; | |||
private readonly logger: Logger; | |||
private deleteConnectionRequestConversation?: (userId: QualifiedId) => Promise<void>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could probably find a naming that suggest it's a callback (here we feel it's going to trigger an imperative action)
* runfix: filter out connection requests with deleted users * test: fix tests * runfix: handle canceling a connection req with deleted user * test: fix test * runfix: handle incoming request case * test: add scenario for deleting local req when loading conversations * test: add scenario for trying to accept/ignore incoming req * refactor: improve callback naming
Description
Checklist