feat: add literal string replacement support for react localizer util #17273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #17273 +/- ##
==========================================
+ Coverage 46.05% 46.08% +0.03%
==========================================
Files 747 747
Lines 24617 24632 +15
Branches 5627 5632 +5
==========================================
+ Hits 11337 11352 +15
Misses 11856 11856
Partials 1424 1424 |
|
PatrykBuniX
added a commit
that referenced
this pull request
May 7, 2024
…#17273) * feat: add literal string replacement support for react localizer util * feat: support string literal inside the component * refactor: improve naming * doc: add a comment
PatrykBuniX
added a commit
that referenced
this pull request
May 7, 2024
* feat: add literal string replacement support for react localizer util (#17273) * feat: add literal string replacement support for react localizer util * feat: support string literal inside the component * refactor: improve naming * doc: add a comment * refactor: readonly conversaiton indication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a support for replacing string literal values in
replaceReactComponentsutil. This will make it easier for us to migrate fromdangerouslySetInnerHtmlin cases we needed it to inject dynamic values into copy templates.Checklist