refactor: readonly conversation indication #17369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#17273) * feat: add literal string replacement support for react localizer util * feat: support string literal inside the component * refactor: improve naming * doc: add a comment
V-Gira
reviewed
May 7, 2024
| "otherUserNotSupportMLSMsg": "You can't communicate with [bold]{{participantName}}[/bold] anymore, as you two now use different protocols. When [bold]{{participantName}}[/bold] gets an update, you can call and send messages and files again.", | ||
| "otherUserNotSupportMLSMsg": "You can't communicate with {{participantName}} anymore, as you two now use different protocols. When {{participantName}} gets an update, you can call and send messages and files again.", |
There was a problem hiding this comment.
Question: Is localisation in German done for those? Might be worth it to cherrypick the localisation commit too if we want to avoid the [bold] tag to appear as a string
There was a problem hiding this comment.
When merged to dev, these changes were made automatically for German
There was a problem hiding this comment.
So I guess it will happen automatically here as well
There was a problem hiding this comment.
Let's see, it didn't work out that way on master last time :|
Let's worry about it when we get there 🤞
V-Gira
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applies changes already merged on dev branch - refactoring of readonly mls conversation indication + improved react localizer util. This is needed for handling new case of marking a conversation as readonly - migrating a conversation with a user that don't have any keys available.
Checklist