runfix: 1:1 conversation with user without key packages (#17371) #17412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: update conversaiton readonly state * runfix: optionally do not allow unestablished mls 1:1 * feat: add a placeholder message for readonly 1:1 with a user without keys * runfix: update copy * test: readonly mls 1:1 no available keys
|
V-Gira
approved these changes
May 16, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #17412 +/- ##
==========================================
- Coverage 46.15% 46.15% -0.01%
==========================================
Files 753 753
Lines 24725 24732 +7
Branches 5668 5671 +3
==========================================
+ Hits 11411 11414 +3
- Misses 11884 11886 +2
- Partials 1430 1432 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked a commit from the release branch that handles an error when cannot establish a MLS 1:1 conversation when the other user has no key packages available. For more details see #17371.