Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace uuidjs with uuid WPB-7240 #17434

Merged
merged 1 commit into from
May 21, 2024

Conversation

svitovyda
Copy link
Contributor

@svitovyda svitovyda commented May 21, 2024

TaskWPB-7240 [web] close open security issues across repositories

Description

Motivation: bump uuidjs from v 4.2.13 to v 5.1.0 causes problems with jest that are hard to resolve.
And since uuid has 103,276,467 weekly downloads vs uuidjs - 9,841, it makes sense to use uuid.

Screenshots/Screencast (for UI changes)

Checklist

  • PR has been self reviewed by the author;

Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 46.07%. Comparing base (d4a97d8) to head (3d67bf2).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #17434   +/-   ##
=======================================
  Coverage   46.06%   46.07%           
=======================================
  Files         754      754           
  Lines       24789    24789           
  Branches     5683     5683           
=======================================
+ Hits        11420    11421    +1     
  Misses      11935    11935           
+ Partials     1434     1433    -1     

Copy link
Contributor

@tlebon tlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good for me

@svitovyda svitovyda merged commit 2cf1358 into dev May 21, 2024
13 checks passed
@svitovyda svitovyda deleted the chore/replace-uuidjs-by-uuid-WPB-7240 branch May 21, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants