runfix: download cert from device settings for basic mls deivce [WPB-9193] #17435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrykBuniX
changed the title
|
przemvs
approved these changes
May 22, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 22, 2024
…9193] (#17435) * runfix: mark the basic device as not e2ei activated * test: not activated cert for basic mls device
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the device is a basic MLS device, corecrypto will mark its identity status as valid. If the status is valid but the device's credential type is basic (1), we should mark the certificate status as "not activated" and allow the user to download the certificate manually.
Screenshots/Screencast (for UI changes)
Before:
Now:
Checklist