Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Image zoom for tiny images #17437

Merged
merged 1 commit into from
May 22, 2024
Merged

feat: Image zoom for tiny images #17437

merged 1 commit into from
May 22, 2024

Conversation

przemvs
Copy link
Contributor

@przemvs przemvs commented May 22, 2024

Description

Fix for zooming not wide image but long - zoom to middle of screen instead of to random position. Same for not long but wide image - zoom to middle of screen.

Fixed also cursor while image is zoomed.

Screenshots/Screencast (for UI changes)

Before:
image

image

Now:
image

image

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

Important details for the reviewers

(Delete this section if unnecessary)

  • use (x) data
  • can be reviewed commit-by-commit
  • be sure to look at ...

Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@przemvs przemvs merged commit f6c03e0 into dev May 22, 2024
11 checks passed
@przemvs przemvs deleted the feat/WPB-1445-image-zoom branch May 22, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants