Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: search for people only in the connect tab (WPB-6561) #17450

Merged
merged 2 commits into from
May 23, 2024
Merged

fix: search for people only in the connect tab (WPB-6561) #17450

merged 2 commits into from
May 23, 2024

Conversation

V-Gira
Copy link
Contributor

@V-Gira V-Gira commented May 23, 2024 •
edited by github-actions bot
Loading

StoryWPB-6561 Adapt search behavior in "Contacts" to really just look for contacts, not groups / conversations

Description

Searching for groups is done in the "Groups" tab in the new navigation.
The connect tab only returns search results for people.

Screenshots/Screencast (for UI changes)

Before:
image

After:
image

@V-Gira V-Gira marked this pull request as ready for review May 23, 2024 13:42
@V-Gira V-Gira requested review from otto-the-bot and a team as code owners May 23, 2024 13:42
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@V-Gira V-Gira merged commit 09ca18a into new-navigation May 23, 2024
10 checks passed
@V-Gira V-Gira deleted the v/remove-groups-connect-search branch May 23, 2024 14:00
@V-Gira V-Gira mentioned this pull request May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrykBuniX PatrykBuniX PatrykBuniX approved these changes

@otto-the-bot otto-the-bot Awaiting requested review from otto-the-bot

Assignees
No one assigned
Labels
👕 size: S type: bug / fix 🐞
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@V-Gira @PatrykBuniX @otto-the-bot