-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Conversation scrolling stops loading following messages #17627
fix: Conversation scrolling stops loading following messages #17627
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #17627 +/- ##
==========================================
- Coverage 46.15% 46.14% -0.02%
==========================================
Files 760 760
Lines 24993 24992 -1
Branches 5721 5720 -1
==========================================
- Hits 11535 11532 -3
- Misses 12015 12017 +2
Partials 1443 1443 |
|
* chore: Update translations (#17619) * chore: type safe icons (#17617) * refactor: move svg provider to root util directory * chore: typesafe config icons * refactor: improve types * chore: improve comment * chore: update ignore files * refactor: move typedEntries to array utils * chore: fix action panel types * refactor: simplify naming * chore: conversation actions type * chore: svg provider mocks type * chore: context menu type * chore: remove license from non-gh file * chore: remove comment * chore: generate react icons at build time (#17621) * chore: Update translations (#17622) * fix: Ephemeral message timer position (#17624) * fix: revert classname for ephemeral message (#17625) * fix: Improve asset downloading and caching (#17626) * fix: Conversation scrolling stops loading following messages (#17627) * fix: Conversation scrolling stops loading following messages * improve types * chore(deps): bump cakeinpanic/jira-description-action (#17629) Bumps [cakeinpanic/jira-description-action](https://github.com/cakeinpanic/jira-description-action) from 0.8.1 to 0.9.0. - [Release notes](https://github.com/cakeinpanic/jira-description-action/releases) - [Changelog](https://github.com/cakeinpanic/jira-description-action/blob/master/CHANGELOG.md) - [Commits](cakeinpanic/jira-description-action@v0.8.1...v0.9.0) --- updated-dependencies: - dependency-name: cakeinpanic/jira-description-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump pm2 from 5.4.0 to 5.4.1 in /server (#17630) Bumps [pm2](https://github.com/Unitech/pm2) from 5.4.0 to 5.4.1. - [Release notes](https://github.com/Unitech/pm2/releases) - [Changelog](https://github.com/Unitech/pm2/blob/master/CHANGELOG.md) - [Commits](Unitech/pm2@v5.4.0...v5.4.1) --- updated-dependencies: - dependency-name: pm2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump typescript from 5.4.5 to 5.5.2 in /server (#17631) Bumps [typescript](https://github.com/Microsoft/TypeScript) from 5.4.5 to 5.5.2. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml) - [Commits](microsoft/TypeScript@v5.4.5...v5.5.2) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump webpack from 5.92.0 to 5.92.1 (#17632) Bumps [webpack](https://github.com/webpack/webpack) from 5.92.0 to 5.92.1. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.92.0...v5.92.1) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump @types/uuid from 9.0.8 to 10.0.0 (#17634) Bumps [@types/uuid](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/uuid) from 9.0.8 to 10.0.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/uuid) --- updated-dependencies: - dependency-name: "@types/uuid" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump @types/node from 20.14.2 to 20.14.8 (#17635) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.14.2 to 20.14.8. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump cssnano from 7.0.2 to 7.0.3 (#17636) Bumps [cssnano](https://github.com/cssnano/cssnano) from 7.0.2 to 7.0.3. - [Release notes](https://github.com/cssnano/cssnano/releases) - [Commits](https://github.com/cssnano/cssnano/compare/cssnano@7.0.2...cssnano@7.0.3) --- updated-dependencies: - dependency-name: cssnano dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * runfix: make no common protocol message more generic (#17637) * runfix: update icons --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Otto the Bot <webapp+otto@wire.com> Co-authored-by: Thomas Belin <thomasbelin4@gmail.com> Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik96@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
https://wearezeta.atlassian.net/browse/WPB-9465
Description
Probably something was wrong while refactoring. Previously we not checking all messages, probably this if checking will fix this issue.
Previously code:
Screenshots/Screencast (for UI changes)
Checklist
Important details for the reviewers
(Delete this section if unnecessary)