feat: Adjust browser notifications to new states (WEBAPP-5562) #4803
Conversation
| const shouldNotify = isEventToNotify && !messageEntity.isEdited() && !messageEntity.isLinkPreview() && !isMuted; | ||
| const ignoreAllNotifications = conversationEntity && conversationEntity.showNotificationsNothing(); | ||
|
|
||
| const showNotificationsOnlyMentions = conversationEntity && conversationEntity.showNotificationsOnlyMentions(); |
There was a problem hiding this comment.
For that kind of heavy logic code, I would probably create a new class that handles filtering the incoming notifications.
The API could be very simple (for the moment at least) with just a pure function that given a message, a connection, a conversation and a user and a notification level returns true if the notification should fire.
It will be easier in the future to bootstrap tests for that class without having to initiate all the dependencies of the NotificationRepository.
Could be done in a follow up PR
ffflorian
force-pushed
the
feat/WEBAPP-5562
branch
2 times, most recently
from
d4a5584
to
5598f44
Compare
ffflorian
force-pushed
the
feat/WEBAPP-5562
branch
from
5598f44
to
50fc591
Compare
ffflorian
force-pushed
the
feat/WEBAPP-5562
branch
from
b5e9e0a
to
820239f
Compare
| * @param {string} userId - The user id to check mentions for. | ||
| * @returns {boolean} If the conversation should send a notification. | ||
| */ | ||
| static _shouldNotify(conversationEntity, messageEntity, userId) { |
There was a problem hiding this comment.
No need for an underscore in the name. This is staic and available for everyone.
| const isEventToNotify = | ||
| NotificationRepository.EVENTS_TO_NOTIFY.includes(messageEntity.super_type) && | ||
| !messageEntity.isEdited() && | ||
| !messageEntity.isLinkPreview(); |
There was a problem hiding this comment.
Can we pull this apart for a little improved readability?
const isEventTypeToNotify = NotificationRepository.EVENTS_TO_NOTIFY.includes(messageEntity.super_type);
const isEventToNotify = isEventTypeToNotify && !messageEntity.isEdited() && !messageEntity.isLinkPreview();
No description provided.