fix: Add a proper binding to handle infinite scroll (WEBAPP-5949) #5922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomrc
force-pushed
the
fix/search_scrolling_behavior
branch
from
59b23dd
to
a844825
Compare
Codecov Report
@@ Coverage Diff @@
## dev #5922 +/- ##
==========================================
+ Coverage 48.71% 48.98% +0.27%
==========================================
Files 327 327
Lines 14314 15172 +858
==========================================
+ Hits 6973 7432 +459
- Misses 7341 7740 +399 |
atomrc
force-pushed
the
fix/search_scrolling_behavior
branch
from
a844825
to
d60cc83
Compare
ffflorian
approved these changes
Feb 28, 2019
AndyLnd
suggested changes
Feb 28, 2019
| /** | ||
| * To avoid reacting to programmatically triggered scroll, we just want to enable the scroll listener when there is a mouse event before it. | ||
| * The strategy here is to enable the scroll listener when there is a mouse event and automatically disable the listener after 500ms of inactivity of the mouse. | ||
| */ |
There was a problem hiding this comment.
I think it might be problematic to only react to the mousewheel event. There are other user interactions that will cause scrolling, selecting chunks of text and dragging the scrollbar for example.
Co-Authored-By: atomrc <thomasbelin4@gmail.com>
Co-Authored-By: atomrc <thomasbelin4@gmail.com>
atomrc
force-pushed
the
fix/search_scrolling_behavior
branch
from
07be565
to
c848b6e
Compare
AndyLnd
approved these changes
Mar 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.