debug: Enable mocked link previews to be generated #5996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomrc
changed the title
ffflorian
approved these changes
Mar 5, 2019
src/script/util/DebugUtil.js
Outdated
| * @returns {void} - returns nothing | ||
| */ | ||
| enableLinkPreviews() { | ||
| /* To allow the LinkPreviewRepository to generate link previews, we need to expose a fake 'openGraphAsync' method. |
There was a problem hiding this comment.
Suggested change
| /* To allow the LinkPreviewRepository to generate link previews, we need to expose a fake 'openGraphAsync' method. | |
| /** | |
| * To allow the LinkPreviewRepository to generate link previews, we need to expose a fake 'openGraphAsync' method. |
Codecov Report
@@ Coverage Diff @@
## dev #5996 +/- ##
==========================================
+ Coverage 48.75% 48.79% +0.03%
==========================================
Files 327 327
Lines 14277 14272 -5
==========================================
+ Hits 6961 6964 +3
+ Misses 7316 7308 -8 |
atomrc
force-pushed
the
debug/enable_link_preview_mock
branch
from
8336c93
to
6062402
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.