Send audio preview #803
Send audio preview #803
Conversation
| window.URL.revokeObjectURL url | ||
| reject new Error('Exceeded video load timeout') | ||
| , 100 | ||
|
|
There was a problem hiding this comment.
you might wanna reject on error?
| , 100 | ||
|
|
||
| _is_video: (file) -> | ||
| file?.type?.startsWith 'video' |
There was a problem hiding this comment.
underscore is used mostly to used mark private functions
.idea/codeStyleSettings.xml
Outdated
| <JSCodeStyleSettings> | ||
| <option name="SPACE_BEFORE_FUNCTION_LEFT_PARENTH" value="false" /> | ||
| </JSCodeStyleSettings> | ||
| <TypeScriptCodeStyleSettings> | ||
| <option name="SPACE_AFTER_TYPE_COLON" value="true" /> | ||
| </TypeScriptCodeStyleSettings> | ||
| <XML> | ||
| <option name="XML_LEGACY_SETTINGS_IMPORTED" value="true" /> |
There was a problem hiding this comment.
Dont need to mention that i am not a big fan of committing the ide files :/
|
|
||
| _normalise_sample: (value) -> | ||
| MAX_VALUE = 255 | ||
| Math.min(Math.abs(parseInt(value * MAX_VALUE, 10)), MAX_VALUE) |
There was a problem hiding this comment.
this could even move into NumberUtil, its totally generic
There was a problem hiding this comment.
[0...5] will exclude the end
| window.setTimeout -> | ||
| window.URL.revokeObjectURL url | ||
| reject new Error('Exceeded image load timeout') | ||
| , 100 |
There was a problem hiding this comment.
it will resolve and reject. whats the idea behind the timeout
| file?.type?.startsWith 'image' | ||
|
|
||
| _generate_preview: (audio_buffer) -> | ||
| MAX_SAMPLES = 200 |
There was a problem hiding this comment.
maybe get_normalized_loudness ?
| for bucket, index in buckets | ||
| preview[index] = @_normalise_sample(@_root_mean_square(bucket) * AMPLIFIER) | ||
| break # only select first channel | ||
| new Uint8Array(preview) |
There was a problem hiding this comment.
so you will use only the left channel for now?
| z.assets.AssetMetaDataBuilder.build_metadata file | ||
| .then (metadata) -> | ||
| asset = new z.proto.Asset() | ||
| if z.assets.AssetMetaDataBuilder.is_audio(file) |
There was a problem hiding this comment.
if z.assets.AssetMetaDataBuilder.is_audio file
.idea/codeStyleSettings.xml
Outdated
| @@ -43,4 +43,4 @@ | |||
| </option> | |||
| <option name="USE_PER_PROJECT_SETTINGS" value="true" /> | |||
| </component> | |||
| </project> | |||
| # Wait before removing resource and link. Needed in FF | ||
| window.setTimeout -> | ||
| window.URL.revokeObjectURL url | ||
| , 100 |
There was a problem hiding this comment.
i think we can get rid of this timeout. it was only valid when you actually download a file using the link approach
|
|
Type of change
Sends audio preview when uploading audio data
Adds builder to construct various types of MetaData
Screenshot