Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix freezer causing error when unfreezing without owner #2479

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

Aws0mee
Copy link
Contributor

@Aws0mee Aws0mee commented Nov 7, 2022

Fixes #2478

@Vurv78
Copy link
Member

Vurv78 commented Nov 7, 2022

Does the CanPlayerUnfreeze hook also need this check?

@Aws0mee
Copy link
Contributor Author

Aws0mee commented Nov 8, 2022

Does the CanPlayerUnfreeze hook also need this check?

No, it does not appear to cause any errors from my testing. Refer to #2478

Copy link
Contributor

@thegrb93 thegrb93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just put an if not IsValid(self:GetPlayer()) then return end at the top of the triggerinput? Pretty sure the other hooks in there will want it.

@Aws0mee
Copy link
Contributor Author

Aws0mee commented Nov 9, 2022

Can you just put an if not IsValid(self:GetPlayer()) then return end at the top of the triggerinput? Pretty sure the other hooks in there will want it.

I can do that, but I feel like there could be cases where we would still want it to work if the owner disconnects. Additionally I saw someone say they set up permanent wire contraptions somewhere in a github issue, so that could interfere with something like that.

@thegrb93
Copy link
Contributor

thegrb93 commented Nov 9, 2022

The only way it will ever work if owner disconnects is if gmod ever got a decent prop protection that works by steamid checks when the owner is disconnected, but I don't see that ever happening.

@Aws0mee
Copy link
Contributor Author

Aws0mee commented Nov 9, 2022

The only way it will ever work if owner disconnects is if gmod ever got a decent prop protection that works by steamid checks when the owner is disconnected, but I don't see that ever happening.

Fair enough, I changed it.

@thegrb93 thegrb93 merged commit ee025a4 into wiremod:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Freezer throws an error when unfreezing without owner
3 participants