Fix over-aggressive date parsing. Closes #653.

CHANGELOG.rst

@@ -1,6 +1,7 @@
 1.5.5
 -----
 
+* :meth:`.Date.cast` will no longer parse strings like :code:`05_leslie3d_base` as dates. (#653)
 * :meth:`.Text.cast` will no longer strip leading or trailing whitespace. (#654)
 * Fixed :code:`'NoneType' object has no attribute 'groupdict'` error in :meth:`.TimeDelta.cast`. (#656)
 

agate/data_types/date.py

@@ -77,16 +77,6 @@ def cast(self, d):
         if ctx.hasDate and not ctx.hasTime:
             return value.date()
 
-        try:
-            dt = isodate.parse_date(d)
-
-            if ctx.hasTime:
-                raise ValueError('isodate.parse_date discarded a time component')
-
-            return dt
-        except (isodate.ISO8601Error, ValueError):
-            pass
-
         raise CastError('Can not parse value "%s" as date.' % d)
 
     def csvify(self, d):

tests/test_data_types.py

@@ -41,6 +41,11 @@ def test_test(self):
         self.assertEqual(self.type.test('a'), True)
         self.assertEqual(self.type.test('A\nB'), True)
         self.assertEqual(self.type.test(u'👍'), True)
+        self.assertEqual(self.type.test('05_leslie3d_base'), True)
+        self.assertEqual(self.type.test('2016-12-29'), True)
+        self.assertEqual(self.type.test('2016-12-29T11:43:30Z'), True)
+        self.assertEqual(self.type.test('2016-12-29T11:43:30+06:00'), True)
+        self.assertEqual(self.type.test('2016-12-29T11:43:30-06:00'), True)
 
     def test_cast(self):
         values = ('a', 1, None, Decimal('2.7'), 'n/a', u'👍', ' foo', 'foo ')
@@ -86,6 +91,11 @@ def test_test(self):
         self.assertEqual(self.type.test('a'), False)
         self.assertEqual(self.type.test('A\nB'), False)
         self.assertEqual(self.type.test(u'👍'), False)
+        self.assertEqual(self.type.test('05_leslie3d_base'), False)
+        self.assertEqual(self.type.test('2016-12-29'), False)
+        self.assertEqual(self.type.test('2016-12-29T11:43:30Z'), False)
+        self.assertEqual(self.type.test('2016-12-29T11:43:30+06:00'), False)
+        self.assertEqual(self.type.test('2016-12-29T11:43:30-06:00'), False)
 
     def test_cast(self):
         values = (True, 'yes', None, False, 'no', 'n/a', '1', 0)
@@ -130,6 +140,11 @@ def test_test(self):
         self.assertEqual(self.type.test('a'), False)
         self.assertEqual(self.type.test('A\nB'), False)
         self.assertEqual(self.type.test(u'👍'), False)
+        self.assertEqual(self.type.test('05_leslie3d_base'), False)
+        self.assertEqual(self.type.test('2016-12-29'), False)
+        self.assertEqual(self.type.test('2016-12-29T11:43:30Z'), False)
+        self.assertEqual(self.type.test('2016-12-29T11:43:30+06:00'), False)
+        self.assertEqual(self.type.test('2016-12-29T11:43:30-06:00'), False)
 
     def test_cast(self):
         values = (2, 1, None, Decimal('2.7'), 'n/a', '2.7', '200,000,000')
@@ -187,6 +202,11 @@ def test_test(self):
         self.assertEqual(self.type.test('a'), False)
         self.assertEqual(self.type.test('A\nB'), False)
         self.assertEqual(self.type.test(u'👍'), False)
+        self.assertEqual(self.type.test('05_leslie3d_base'), False)
+        self.assertEqual(self.type.test('2016-12-29'), True)
+        self.assertEqual(self.type.test('2016-12-29T11:43:30Z'), False)
+        self.assertEqual(self.type.test('2016-12-29T11:43:30+06:00'), False)
+        self.assertEqual(self.type.test('2016-12-29T11:43:30-06:00'), False)
 
     def test_test_format(self):
         date_type = Date(date_format='%m-%d-%Y')
@@ -260,6 +280,11 @@ def test_test(self):
         self.assertEqual(self.type.test('a'), False)
         self.assertEqual(self.type.test('A\nB'), False)
         self.assertEqual(self.type.test(u'👍'), False)
+        self.assertEqual(self.type.test('05_leslie3d_base'), False)
+        self.assertEqual(self.type.test('2016-12-29'), True)
+        self.assertEqual(self.type.test('2016-12-29T11:43:30Z'), True)
+        self.assertEqual(self.type.test('2016-12-29T11:43:30+06:00'), True)
+        self.assertEqual(self.type.test('2016-12-29T11:43:30-06:00'), True)
 
     def test_test_format(self):
         datetime_type = DateTime(datetime_format='%m-%d-%Y %I:%M %p')
@@ -350,6 +375,11 @@ def test_test(self):
         self.assertEqual(self.type.test('a'), False)
         self.assertEqual(self.type.test('A\nB'), False)
         self.assertEqual(self.type.test(u'👍'), False)
+        self.assertEqual(self.type.test('05_leslie3d_base'), False)
+        self.assertEqual(self.type.test('2016-12-29'), False)
+        self.assertEqual(self.type.test('2016-12-29T11:43:30Z'), False)
+        self.assertEqual(self.type.test('2016-12-29T11:43:30+06:00'), False)
+        self.assertEqual(self.type.test('2016-12-29T11:43:30-06:00'), False)
 
     def test_cast_parser(self):
         values = ('4:10', '1.2m', '172 hours', '5 weeks, 2 days', 'n/a')