Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error/warn when converting JSON with nested values #366

Closed
onyxfish opened this issue Nov 27, 2014 · 8 comments
Closed

Error/warn when converting JSON with nested values #366

onyxfish opened this issue Nov 27, 2014 · 8 comments
Milestone

Comments

@onyxfish
Copy link
Collaborator

See #365.

@konklone
Copy link

From #365:

but in2csv doesn't support nested properties for JSON, so the contents of "address" are being ignored. I've created a new ticket to trap this error, but it is not considered a bug at this moment.

I know you're the author of the library, but are you sure? convert.py advertises support for recursive flattening, and I personally remember it doing so when I used it in 2013 and early 2014.

When I built http://konklone.io/json/ in early 2014, I literally just ported that recursive flattening algorithm in csvkit from Python to JavaScript, and my converter handles nested JSON just fine.

I think csvkit was originally written to handle nested JSON, and had a regression at some point.

@onyxfish
Copy link
Collaborator Author

Hmmm, I may be wrong, I'll check back through the changelog. Thanks for letting me know!

@marks
Copy link

marks commented Mar 1, 2015

Any update here? Very interested in this feature in in2csv (as you can probably tell from my recent tweets) :)

@jpmckinney
Copy link
Member

346f352 is the commit that broke it.

@jpmckinney
Copy link
Member

See #476

jpmckinney pushed a commit that referenced this issue Jan 23, 2016
@bensonism
Copy link

Hey, I'm having the same issue after using pip install. Do I have to compile the code from the repo to get the fix for this?

@jpmckinney
Copy link
Member

Yes, try:

pip install --upgrade -e git+git://github.com/wireservice/csvkit.git@master#egg=csvkit

@bensonism
Copy link

oh snap! you are amazing. <3

On Fri, Oct 14, 2016 at 2:07 PM, James McKinney notifications@github.com
wrote:

Yes, try:

pip install --upgrade -e git+git://github.com/wireservice/csvkit.git@master#egg=csvkit


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#366 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATdJw2TnXjkadspW-gNc_usWZACjvEZKks5qz9LrgaJpZM4DBf00
.

_Jeremy Benson | LAMP Developer_GO LOCAL INTERACTIVE
http://www.golocalinteractive.com/

Corporate Woods Building 12
10975 Benson Drive, Suite 250
Overland Park, KS 66210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants