Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Keep Inventory Gamerule dose not prevent dropping of Accessories #27

Closed
No1129 opened this issue Jun 5, 2024 · 2 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@No1129
Copy link

No1129 commented Jun 5, 2024

Items in accessories slots still drop with keep inventory on.

} else if (dropRule == DropRule.DEFAULT) { if (entity.level().getGameRules().getRule(GameRules.RULE_KEEPINVENTORY).get()) { dropStack = true;
its set to true
this may be the issue

@Dragon-Seeker
Copy link
Member

Yes, it dose seem that that logic is incorrect... whoops. Will be pushing an update for such coming up

@Dragon-Seeker Dragon-Seeker changed the title [Bug?] Keep inventory does not work [Bug] Keep Inventory Gamerule dose not prevent dropping of Accessories Jun 5, 2024
@Dragon-Seeker Dragon-Seeker self-assigned this Jun 5, 2024
@Dragon-Seeker Dragon-Seeker added the bug Something isn't working label Jun 5, 2024
@Dragon-Seeker
Copy link
Member

An update was pushed to fix this issue on modrinth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants