Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for number ranges #2579

Open
PAK90 opened this issue Jan 17, 2023 · 3 comments
Open

Add support for number ranges #2579

PAK90 opened this issue Jan 17, 2023 · 3 comments

Comments

@PAK90
Copy link

PAK90 commented Jan 17, 2023

Do you want to request a feature, report a bug, or ask a question about wit?
Feature

What is the current behavior?
Numbers can't have ranges.

What is the expected behavior?
Numbers should have ranges, like wit/amount_of_money

Oddly, I asked for this exact feature years ago in this issue. It has been closed and so has the relevant duckling issue. But in today's wit.ai, I still cannot see ranges as supported by wit/number. Is this a hidden feature/setting somewhere, or it's simply never made it into the wit.ai site?

@MokhtarKhorshid
Copy link

MokhtarKhorshid commented Jan 17, 2023

What would you expect to happen if the user says a number that's outside the given range? Or did you mean you want it to resolve to a range?

@PAK90
Copy link
Author

PAK90 commented Jan 17, 2023

I want to have a number entity, for example from the sentence more than 90 seconds. This currently just picks out 90 as a number, for which I can't declare a range. It'd be good to have it behave like wit/amount_of_money does, where you can do less than $5 and it picks up the range and currency.

@patapizza
Copy link
Member

hey @PAK90, this isn't supported at this point. But like wit/amount_of_money, wit/number is supported by Duckling - so feel free to take a stab at it and submit a PR! One caveat is that many other dimensions are built on top of the Numeral dimension, so we'd need to move the implementation of ranges from that higher dimension to the lower one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants