Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Third-Party override of esbuild expose settings #56

Closed
alexanderniebuhr opened this issue Nov 10, 2023 · 1 comment
Closed

Allow Third-Party override of esbuild expose settings #56

alexanderniebuhr opened this issue Nov 10, 2023 · 1 comment
Labels
- P2: nice to have Not breaking anything but nice to have (priority) good first issue Good for newcomers pkg: cloudflare

Comments

@alexanderniebuhr
Copy link
Member

alexanderniebuhr commented Nov 10, 2023

Objective: We aim to enhance our adapter's flexibility and customization capabilities by exposing a subset of esbuild settings. This will enable third-party developers to override the default configurations set by our adapter with custom ones tailored to their specific needs. And to implement workarounds needed.

Background: Our current setup comes with a default configuration for esbuild that suits most use cases and follows the best-practices. However, we acknowledge the diversity of our user base and their unique requirements. By opening up the adapter for configuration overrides, we can accommodate a wider range of use-cases.

Scope of Work:

We think considering all esbuild settings should be the goal. The API could work similar to Astro's inline Vite config. Definitely we should support, external, plugins, platform, conditions

Overrides: It is important to note that, in this initial idea, we will not support merging custom configurations with the default settings. Users will need to specify their configurations fully, as these will entirely replace the defaults.

Considerations: Depending on the amount of work, we may want to opt for configuration merging. This would allow users to modify only parts of the configuration while keeping the rest as defaults.

Guidelines:

Docs: The implementation should be followed by clear documentation in the https://github.com/withastro/docs repository.

Tests: The implementation should also be provided with suitable tests (preferably using the node test runner #150)


Support: If you have any questions or need clarification on the task, please ask in the comments section of this issue early and often. Our team is here to help and provide guidance.

@alexanderniebuhr alexanderniebuhr self-assigned this Nov 10, 2023
@alexanderniebuhr alexanderniebuhr added pkg: cloudflare - P2: nice to have Not breaking anything but nice to have (priority) labels Nov 10, 2023
@alexanderniebuhr alexanderniebuhr changed the title Expose esbuild options expose options of multiple steps in the pipeline (esbuild, miniflare, ...) Nov 12, 2023
@alexanderniebuhr alexanderniebuhr removed their assignment Feb 3, 2024
@alexanderniebuhr alexanderniebuhr added the good first issue Good for newcomers label Feb 3, 2024
@alexanderniebuhr alexanderniebuhr changed the title expose options of multiple steps in the pipeline (esbuild, miniflare, ...) Allow Third-Party override of esbuild expose settings Feb 5, 2024
@alexanderniebuhr
Copy link
Member Author

With the upcoming v10 version, we'll don't have the esbuild step anymore. So this is not needed anymore.

@alexanderniebuhr alexanderniebuhr closed this as not planned Won't fix, can't repro, duplicate, stale Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P2: nice to have Not breaking anything but nice to have (priority) good first issue Good for newcomers pkg: cloudflare
Projects
None yet
Development

No branches or pull requests

1 participant