Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: @builder.io/sdk-solid not working with Astro #3338

Closed
1 task
FredKSchott opened this issue May 10, 2022 · 3 comments
Closed
1 task

🐛 BUG: @builder.io/sdk-solid not working with Astro #3338

FredKSchott opened this issue May 10, 2022 · 3 comments
Assignees
Labels
- P4: important Violate documented behavior or significantly impacts performance (priority)

Comments

@FredKSchott
Copy link
Member

What version of astro are you using?

latest

Are you using an SSR adapter? If so, which one?

none

What package manager are you using?

npm

What operating system are you using?

mac

Describe the Bug

Hey Fred! I'm Sami, an engineer at Builder.io who's focused on our SDKs. I'm helping Steve out with our SolidJS + Astro example and trying to get it to the finish line!

I have a bit of an odd issue that I'm hoping you can provide guidance on 🙏🏽. Trying to import our SolidJS SDK causes an error regarding .jsx extensions (see screenshot).

  • This error does not occur with the exact same code in a Solid starter.
  • Both examples use the same vite config.
  • I believe we've fixed our SDK to be a proper ESM package now.

Here is the reproduction: https://github.com/samijaber/builder/tree/fix/solidjs-sdk/examples/astro-solidjs

(You can reproduce by installing @builder.io/sdk-solid@0.0.8-3 and trying to import it in the App.jsx of an Astro project, as in the reproduction repo linked above)

Any idea why Astro would have difficulty with this? :thinkdrops:

unknown

Link to Minimal Reproducible Example

https://github.com/samijaber/builder/tree/fix/solidjs-sdk/examples/astro-solidjs

Participation

  • I am willing to submit a pull request for this issue.
@FredKSchott FredKSchott added - P4: important Violate documented behavior or significantly impacts performance (priority) s2-medium labels May 10, 2022
@FredKSchott
Copy link
Member Author

Fred probably okay to close, but revisit #3350 to make sure no remaining issues

@samijaber
Copy link
Contributor

To add more context from Discord:

In the current version of the @builder.io/sdk-solid (0.0.8-6), the code gets imported just fine by Astro. However, if we attempt to npm link that same version of the SDK into an Astro project, then we hit the .jsx unknown extension issues. It seems to be tied/caused by npm linking for some reason...

@FredKSchott
Copy link
Member Author

Closed by #3350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P4: important Violate documented behavior or significantly impacts performance (priority)
Projects
None yet
Development

No branches or pull requests

2 participants