Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing attribute to button #9762

Merged
merged 2 commits into from
Jan 22, 2024
Merged

fix: add missing attribute to button #9762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8e603a
fix: add missing attribute to button
ematipico Jan 22, 2024
43f8fb3
feedback
ematipico Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/lazy-fireants-clap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"astro": patch
---

Adds `popovertarget" to the attribute that can be passed to the `button` element
2 changes: 2 additions & 0 deletions packages/astro/astro-jsx.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,6 +647,7 @@ declare namespace astroHTML.JSX {
name?: string | undefined | null;
type?: 'submit' | 'reset' | 'button' | undefined | null;
value?: string | string[] | number | undefined | null;
popovertarget?: string | undefined | null;
ematipico marked this conversation as resolved.
Show resolved Hide resolved
}

interface CanvasHTMLAttributes extends HTMLAttributes {
Expand Down Expand Up @@ -811,6 +812,7 @@ declare namespace astroHTML.JSX {
type?: HTMLInputTypeAttribute | undefined | null;
value?: string | string[] | number | undefined | null;
width?: number | string | undefined | null;
popovertarget?: string | undefined | null;
}

interface KeygenHTMLAttributes extends HTMLAttributes {
Expand Down