Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental Deno package from compiler (unmaintained) #534

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

natemoo-re
Copy link
Member

Changes

  • We last published astro_compiler to Deno 6 months ago. It's not maintained and nobody is using it (to the best of my knowledge).
  • We had to commit the astro.wasm file as an artifact so the Deno package could use it. This was causing lots of headaches while rebasing TSX Sourcemaps #518. Better to just remove the package since it's not maintained

Testing

N/A

Docs

N/A, QoL improvement

@changeset-bot
Copy link

changeset-bot bot commented Sep 30, 2022

⚠️ No Changeset found

Latest commit: 2c8d1dc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jasikpark
Copy link
Contributor

could not find it on deno.land 🤷‍♀️

Copy link
Contributor

@jasikpark jasikpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@natemoo-re natemoo-re merged commit ed7bb47 into main Sep 30, 2022
@natemoo-re natemoo-re deleted the chore/drop-deno branch September 30, 2022 20:42
@cowboyd cowboyd mentioned this pull request Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants