Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tutorial] Improve "next steps" at end of tutorial #8507

Merged
merged 3 commits into from
Jun 13, 2024
Merged

[tutorial] Improve "next steps" at end of tutorial #8507

merged 3 commits into from
Jun 13, 2024

Conversation

sarah11918
Copy link
Member

Description (required)

This PR fixes the duplicate "next steps" at the end of the tutorial, and makes them prettier with the <LinkCard> components!

@vercel Vercel
Copy link

vercel bot commented Jun 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 0:55am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Jun 13, 2024 0:55am

@sarah11918 sarah11918 mentioned this pull request Jun 13, 2024
Merged
5 tasks
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jun 13, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en tutorial/6-islands/3.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

BryceRussell
BryceRussell approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@BryceRussell BryceRussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sasoria
sasoria approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@sasoria sasoria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Fryuni
Fryuni approved these changes Jun 13, 2024
View reviewed changes
src/content/docs/en/tutorial/6-islands/3.mdx Outdated Show resolved Hide resolved
at-the-vr
at-the-vr reviewed Jun 13, 2024
View reviewed changes
Copy link
Member

@at-the-vr at-the-vr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 1 doubt as per usual

HiDeoo
HiDeoo approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great CTAs

sarah11918 and others added 2 commits June 13, 2024 09:45
@sarah11918 @Fryuni
remove blank line
ea2f543 
Co-authored-by: Luiz Ferraz <luiz@lferraz.com>
@sarah11918
Merge branch 'main' into tutorial-next-steps
6b92d45
@sarah11918
Copy link
Member Author

!coauthor

@github-actions GitHub Actions
Copy link 

Co-authored-by: Houston (Bot) <108291165+astrobot-houston@users.noreply.github.com>
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
Co-authored-by: Sergio A. Arevalo Soria <sergio.alberto.arevalo.soria@nav.no>
Co-authored-by: Luiz Ferraz <luiz@lferraz.com>
Co-authored-by: Bryce Russell <brycetrussell@gmail.com>
Co-authored-by: Atharva <atharvapise19@gmail.com>

@sarah11918 sarah11918 merged commit b5dbd53 into main Jun 13, 2024
7 of 8 checks passed
@sarah11918 sarah11918 deleted the tutorial-next-steps branch June 13, 2024 12:53
@jsparkdev jsparkdev mentioned this pull request Jun 14, 2024
Merged
@liruifengv liruifengv mentioned this pull request Jun 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@at-the-vr at-the-vr at-the-vr left review comments

@HiDeoo HiDeoo HiDeoo approved these changes

@sasoria sasoria sasoria approved these changes

@Fryuni Fryuni Fryuni approved these changes

@BryceRussell BryceRussell BryceRussell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sarah11918 @astrobot-houston @HiDeoo @sasoria @Fryuni @BryceRussell @at-the-vr